Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Add ability to request serverAuthCode on Android #1704

Closed
wants to merge 8 commits into from

Conversation

ambernardino
Copy link

@ambernardino ambernardino commented Jun 4, 2019

Description

Before this it was not possible to request an authCode from GoogleSignIn in order to authenticate with a backend.

Related Issues

flutter/flutter#16613

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ambernardino
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 4, 2019
@cyanglaz
Copy link
Contributor

cyanglaz commented Jul 8, 2019

It seems to be similar to #879.
@ambernardino Is your PR trying to do the same thing as the other PR?

@collinjackson
Copy link
Contributor

collinjackson commented Jul 16, 2019

It seems to be similar to #879.
@ambernardino Is your PR trying to do the same thing as the other PR?

It seems they are solving similar problems. This one is Android-only and is using what's in google-services.json whereas #879 is requiring the developer to pass the serverClientID manually.

It would be good to have this functionality on both iOS and Android if possible.

@cyanglaz
Copy link
Contributor

Closing this PR since it doesn't have iOS implementation.
#2116 seems have both implementations.

@cyanglaz cyanglaz closed this Oct 15, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Add macOS support

* Use soft links to share code

* Use a different header file for MacOS

* Remove header file from darwin

* Add macos example directory

* Set platform

* Add xcworkspace

Co-authored-by: Collin Jackson <[email protected]>
Co-authored-by: Francisco Magdaleno <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants