-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_sign_in] Add ability to request serverAuthCode on Android #1704
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
It seems to be similar to #879. |
It seems they are solving similar problems. This one is Android-only and is using what's in google-services.json whereas #879 is requiring the developer to pass the It would be good to have this functionality on both iOS and Android if possible. |
Closing this PR since it doesn't have iOS implementation. |
* Add macOS support * Use soft links to share code * Use a different header file for MacOS * Remove header file from darwin * Add macos example directory * Set platform * Add xcworkspace Co-authored-by: Collin Jackson <[email protected]> Co-authored-by: Francisco Magdaleno <[email protected]>
Description
Before this it was not possible to request an authCode from GoogleSignIn in order to authenticate with a backend.
Related Issues
flutter/flutter#16613
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?