[google_sign_in] Add serverClientId option to return serverAuthCode #879

fbcouch · 2018-11-01T17:30:30Z

This should fix issues flutter/flutter#16613 and flutter/flutter#17813

There are a number of formatting changes introduced by the flutter_plugin_tool...I'm happy to back those out if desired.

googlebot · 2018-11-01T17:30:37Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

fbcouch · 2018-11-01T19:11:27Z

Also should fix flutter/flutter#14245

googlebot · 2018-11-02T06:33:16Z

CLAs look good, thanks!

fbcouch · 2018-11-20T19:49:43Z

@kroike (Not sure if you are the right person to ping) Any chance of getting a review on this?

fbcouch · 2018-11-26T16:48:25Z

@kroikie (mis-spelled the first time) Any chance of getting a review on this?

fbcouch · 2019-01-17T19:11:05Z

@bparrishMines any chance of getting a review on this?

DJafari · 2019-02-04T01:36:09Z

@bparrishMines When will this pullRequest to be confirmed and merged ?

crisp00 · 2019-02-21T11:03:59Z

This is a necessary feature. Would love to see this merged! @bparrishMines

bparrishMines · 2019-02-22T23:14:18Z

Hi @fbcouch,

Thank you for the contribution!

Unfortunately, we currently don't have a harness for testing the platform side of plugins, current and new features are not properly covered by tests. In order to maintain a quality bar for flutter/plugins we are going to avoid adding new features that aren't critical until they can be properly tested.

The test harness work is tracked in flutter/flutter#10824 and flutter/flutter#26080, your feedback on the testing work will be really appreciated (will it properly support the testing needs of this PR?) some design details should be available on flutter/flutter#10824 soon(contributions to that effort are welcomed!).

Would you mind re-opening this PR with e2e tests once a test harness is ready?

Meanwhile, you can use this branch in your project by including the lines below in your pubspec.yaml.

dependencies:
  google_sign_in:
    git:
      url: git://github.com/fbcouch/plugins.git
      path: packages/google_sign_in
      ref: server-auth-code

jakebonk · 2019-03-19T16:06:21Z

any idea when this will get pulled?

…. Relates to issues #16613 and #17813

…rverAuthCode on android so that the server always gets the refresh token

fbcouch · 2019-03-19T19:36:55Z

@bparrishMines Do you know if all of this will be usable with those test harnesses? In the specific case of this PR, we need to get a code from one google client ID for another google client ID and then exchange that code for an access token (as you would on a server) and check if it has a refresh token or not. To be honest, since this meets my needs, it's not likely I'm going to set all of that up for this small change, so someone else may want to take over from here.

Arunscape · 2019-04-13T07:57:45Z

apologies for probably just being a n00b here 🙈 , but can we get an example with using this new option?
currently, server-side I can return something like:

{"token_type":"Bearer","access_token":"ya...","scope":"email profile https://www.googleapis.com/auth/userinfo.profile openid https://www.googleapis.com/auth/userinfo.email","login_hint":"...","expires_in":3599,"id_token":"ey...","session_state":{"extraQueryParams":{"authuser":"0"}}}

from my understanding from peeking at the code, the intended way to login with the flutter library is like:

GoogleSignIn _googleSignIn = GoogleSignIn(
  serverClientId: <insert server client id here>, // NEW: add cliend id here
  scopes: <String>[
    <the scopes you want>,
  ],
);

Future<void> login() async {
  try {
    await _googleSignIn.signIn();
  } catch (error) {
    print(error);
  }
}

am I missing anything? (probably something simple I just overlooked such as additional configuration needed... :/)

tl;dr attempting to authenticate without firebase, is this even the right way to attempt this?

fbcouch · 2019-04-13T13:18:51Z

Try calling await _googleSignIn.signOut(); before signIn...I'm not 100% sure if you need that every time or only once in order to get the refresh token

cyanglaz

Thank you for providing this PR! I just did the first round of review.
It mostly looks good. I left some comments for certain places.
We also need dart side unit test for this new parameter to be added.

We would also need E2E test to merge this PR as mentioned by @bparrishMines.

cyanglaz · 2019-04-17T17:17:08Z

...google_sign_in/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

@@ -246,6 +255,10 @@ public void init(
        if (!Strings.isNullOrEmpty(hostedDomain)) {
          optionsBuilder.setHostedDomain(hostedDomain);
        }
+        if (!Strings.isNullOrEmpty(serverClientId)) {
+          optionsBuilder.requestServerAuthCode(serverClientId, true);


If we need to expose this API, let's also expose the boolean parameter forceCodeForRefreshToken to the public API and make it false by default.

cyanglaz · 2019-04-17T17:20:15Z

packages/google_sign_in/ios/Classes/GoogleSignInPlugin.m

@@ -75,6 +75,9 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
        [GIDSignIn sharedInstance].clientID = plist[kClientIdKey];
        [GIDSignIn sharedInstance].scopes = call.arguments[@"scopes"];
        [GIDSignIn sharedInstance].hostedDomain = call.arguments[@"hostedDomain"];
+        if (![call.arguments[@"serverClientId"] isEqual:[NSNull null]]) {


nit:

Suggested change

if (![call.arguments[@"serverClientId"] isEqual:[NSNull null]]) {

if ([call.arguments[@"serverClientId"] isKindOfClass:[NSString class]]) {

cyanglaz · 2019-04-17T17:21:26Z

...google_sign_in/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

@@ -246,6 +255,10 @@ public void init(
        if (!Strings.isNullOrEmpty(hostedDomain)) {
          optionsBuilder.setHostedDomain(hostedDomain);
        }
+        if (!Strings.isNullOrEmpty(serverClientId)) {
+          optionsBuilder.requestServerAuthCode(serverClientId, true);
+          optionsBuilder.requestIdToken(serverClientId);


Is this required? Why do we not have the same on iOS? What happens if this block also calls requestIdToken?

if (clientIdIdentifier != 0) { optionsBuilder.requestIdToken(registrar.context().getString(clientIdIdentifier)); }

cyanglaz · 2019-04-17T17:22:58Z

packages/google_sign_in/lib/google_sign_in.dart

@@ -163,14 +165,17 @@ class GoogleSignIn {
  /// The [hostedDomain] argument specifies a hosted domain restriction. By
  /// setting this, sign in will be restricted to accounts of the user in the
  /// specified domain. By default, the list of accounts will not be restricted.
-  GoogleSignIn({this.signInOption, this.scopes, this.hostedDomain});
+  GoogleSignIn(


Needs dart doc for serverClientId as well.

cyanglaz · 2019-04-17T17:23:10Z

packages/google_sign_in/lib/google_sign_in.dart

@@ -207,6 +212,8 @@ class GoogleSignIn {
  /// Domain to restrict sign-in to.
  final String hostedDomain;

+  final String serverClientId;


Needs dart doc

knvpk · 2019-04-27T06:18:37Z

I just tried this code in my project, but im getting the below error

E/flutter (30432): [ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: PlatformException(exception, two different server client ids provided, null)
E/flutter (30432): #0      StandardMethodCodec.decodeEnvelope 
package:flutter/…/services/message_codecs.dart:564
E/flutter (30432): #1      MethodChannel.invokeMethod 
package:flutter/…/services/platform_channel.dart:302
E/flutter (30432): <asynchronous suspension>
E/flutter (30432): #2      GoogleSignIn._ensureInitialized
package:google_sign_in/google_sign_in.dart:252
E/flutter (30432): #3      GoogleSignIn._callMethod
package:google_sign_in/google_sign_in.dart:228
E/flutter (30432): <asynchronous suspension>
E/flutter (30432): #4      GoogleSignIn._addMethodCall
package:google_sign_in/google_sign_in.dart:276
E/flutter (30432): #5      GoogleSignIn.signOut
package:google_sign_in/google_sign_in.dart:354

But im pretty sure that calling the below code only once

GoogleSignIn _googleSignIn = GoogleSignIn(
    serverClientId: Environment.googleClientId,
    scopes: [
      'profile',
      'email',
      'https://www.googleapis.com/auth/contacts.readonly',
    ],
  );

Infact i have only one google clinet id, i dont know how other one came

knvpk · 2019-04-28T05:36:10Z

It is not the package problem, i used firebase and own client id, i just copied the clinet id from googleservies.json to this package. and it is working fine.

knvpk · 2019-04-30T04:51:42Z

I have checked the code working fine, but signInSilently is always getting null if we provided the own clinet id otherwise working fine.

dbbd59 · 2019-06-28T15:54:34Z

any updates?

cyanglaz · 2019-07-08T17:49:33Z

@fbcouch Seems like you have not been actively working on this for a while. Are you still able to work on this?

fbcouch · 2019-07-09T16:37:17Z

@cyanglaz I might circle back eventually, but it will probably be awhile. If someone else wants to take it over, that's fine with me.

klavergne · 2019-08-28T05:07:57Z

I started modifying the google_sign_in plugin in the same manner as this PR, but I got the same error as @pavankumarkatakam.

E/flutter (30432): [ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: PlatformException(exception, two different server client ids provided, null)

I'm using Firebase and I want to get the auth code so I can pass it to my server. I'm wondering if Firebase is setting the serverClientId silently, and the Java class can't handle 2 of them.

ankurpandeyvns · 2019-09-17T09:36:32Z

I started modifying the google_sign_in plugin in the same manner as this PR, but I got the same error as @pavankumarkatakam.
E/flutter (30432): [ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: PlatformException(exception, two different server client ids provided, null)
I'm using Firebase and I want to get the auth code so I can pass it to my server. I'm wondering if Firebase is setting the serverClientId silently, and the Java class can't handle 2 of them.

Were you able to solve it?

klavergne · 2019-09-17T14:11:12Z

I started modifying the google_sign_in plugin in the same manner as this PR, but I got the same error as @pavankumarkatakam.
E/flutter (30432): [ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: PlatformException(exception, two different server client ids provided, null)
I'm using Firebase and I want to get the auth code so I can pass it to my server. I'm wondering if Firebase is setting the serverClientId silently, and the Java class can't handle 2 of them.
Were you able to solve it?

No. I haven't tried to move forward with it. I'm using Firebase with Google Sign In, and I assume that there's something in the Firebase Android/iOS library that is setting (or adding) a server client id, because it's required to use Firebase, but that's not clearly documented. So, if you want to use Firebase you can't set your own server client id to enable authorization code flow for your server.

cyanglaz · 2019-10-15T00:08:43Z

Since the author is not able to working on this any time soon. I am closing this PR.
The same issue has been worked on by @yamarkz recently in #2116

PJosue100 · 2020-08-10T15:17:04Z

Esto debería solucionar los problemas de flutter / flutter # 16613 y flutter / flutter # 17813

Hay una serie de cambios de formato introducidos por flutter_plugin_tool ... Estoy feliz de retirarlos si lo desea.

Does anyone know how to implement the serverClientId option to return serverAuthCode?

googlebot added the cla: no label Nov 1, 2018

fbcouch force-pushed the server-auth-code branch from 56fbd63 to 46c4bfc Compare November 1, 2018 17:48

googlebot added cla: yes and removed cla: no labels Nov 2, 2018

xster requested a review from bparrishMines December 13, 2018 00:06

DJafari mentioned this pull request Feb 4, 2019

google_sign_in - Using custom back-end id to get token flutter/flutter#17813

Closed

bparrishMines changed the title ~~Add serverClientId option to return serverAuthCode~~ [google_sign_in] Add serverClientId option to return serverAuthCode Feb 22, 2019

bparrishMines added the feature label Feb 22, 2019

fbcouch added 2 commits March 19, 2019 14:21

[server-auth-code] Add serverClientId option to return serverAuthCode…

f5dee16

…. Relates to issues #16613 and #17813

[server-auth-code] Add 'forceCodeForRefreshToken' option to requestSe…

82ffca6

…rverAuthCode on android so that the server always gets the refresh token

fbcouch force-pushed the server-auth-code branch from 67e3992 to 82ffca6 Compare March 19, 2019 19:25

cyanglaz reviewed Apr 17, 2019

View reviewed changes

cyanglaz mentioned this pull request Apr 17, 2019

[google_sign_in] Adding serverClientID optional argument, support for both iOS and Android #1475

Closed

13 tasks

cyanglaz mentioned this pull request Jul 8, 2019

[google_sign_in] Add ability to request serverAuthCode on Android #1704

Closed

13 tasks

yamarkz mentioned this pull request Sep 27, 2019

[google_sign_in] Add ability to return serverAuthCode #2116

Merged

13 tasks

cyanglaz closed this Oct 15, 2019

fbcouch mentioned this pull request Dec 20, 2020

[google_sign_in] Fix issue obtaining serverAuthCode on Android and add forceCodeForRefreshToken parameter #3356

Merged

13 tasks

dreenot mentioned this pull request Apr 27, 2021

[google_sign_in] Fix issue obtaining serverAuthCode on Android and add forceCodeForRefreshToken parameter // Update #3829

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_sign_in] Add serverClientId option to return serverAuthCode #879

[google_sign_in] Add serverClientId option to return serverAuthCode #879

fbcouch commented Nov 1, 2018 •

edited

Loading

googlebot commented Nov 1, 2018

fbcouch commented Nov 1, 2018

googlebot commented Nov 2, 2018

fbcouch commented Nov 20, 2018

fbcouch commented Nov 26, 2018

fbcouch commented Jan 17, 2019

DJafari commented Feb 4, 2019

crisp00 commented Feb 21, 2019

bparrishMines commented Feb 22, 2019

jakebonk commented Mar 19, 2019

fbcouch commented Mar 19, 2019

Arunscape commented Apr 13, 2019 •

edited

Loading

fbcouch commented Apr 13, 2019

cyanglaz left a comment •

edited

Loading

cyanglaz Apr 17, 2019

cyanglaz Apr 17, 2019

cyanglaz Apr 17, 2019

cyanglaz Apr 17, 2019

cyanglaz Apr 17, 2019

knvpk commented Apr 27, 2019 •

edited

Loading

knvpk commented Apr 28, 2019

knvpk commented Apr 30, 2019 •

edited

Loading

dbbd59 commented Jun 28, 2019

cyanglaz commented Jul 8, 2019

fbcouch commented Jul 9, 2019

klavergne commented Aug 28, 2019

ankurpandeyvns commented Sep 17, 2019

klavergne commented Sep 17, 2019

cyanglaz commented Oct 15, 2019

PJosue100 commented Aug 10, 2020

	if (![call.arguments[@"serverClientId"] isEqual:[NSNull null]]) {
	if ([call.arguments[@"serverClientId"] isKindOfClass:[NSString class]]) {

[google_sign_in] Add serverClientId option to return serverAuthCode #879

[google_sign_in] Add serverClientId option to return serverAuthCode #879

Conversation

fbcouch commented Nov 1, 2018 • edited Loading

googlebot commented Nov 1, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

fbcouch commented Nov 1, 2018

googlebot commented Nov 2, 2018

fbcouch commented Nov 20, 2018

fbcouch commented Nov 26, 2018

fbcouch commented Jan 17, 2019

DJafari commented Feb 4, 2019

crisp00 commented Feb 21, 2019

bparrishMines commented Feb 22, 2019

jakebonk commented Mar 19, 2019

fbcouch commented Mar 19, 2019

Arunscape commented Apr 13, 2019 • edited Loading

fbcouch commented Apr 13, 2019

cyanglaz left a comment • edited Loading

Choose a reason for hiding this comment

cyanglaz Apr 17, 2019

Choose a reason for hiding this comment

cyanglaz Apr 17, 2019

Choose a reason for hiding this comment

cyanglaz Apr 17, 2019

Choose a reason for hiding this comment

cyanglaz Apr 17, 2019

Choose a reason for hiding this comment

cyanglaz Apr 17, 2019

Choose a reason for hiding this comment

knvpk commented Apr 27, 2019 • edited Loading

knvpk commented Apr 28, 2019

knvpk commented Apr 30, 2019 • edited Loading

dbbd59 commented Jun 28, 2019

cyanglaz commented Jul 8, 2019

fbcouch commented Jul 9, 2019

klavergne commented Aug 28, 2019

ankurpandeyvns commented Sep 17, 2019

klavergne commented Sep 17, 2019

cyanglaz commented Oct 15, 2019

PJosue100 commented Aug 10, 2020

fbcouch commented Nov 1, 2018 •

edited

Loading

Arunscape commented Apr 13, 2019 •

edited

Loading

cyanglaz left a comment •

edited

Loading

knvpk commented Apr 27, 2019 •

edited

Loading

knvpk commented Apr 30, 2019 •

edited

Loading