This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update plugin_platform_interface min version #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid intra-repo plugin conflicts during the NNBD stable migration, `plugin_platform_interface` allowed either 1.x or 2.0. However, 1.0.x isn't null-safe so this can cause apps that don't have all their packages fully updated can fail to run in strong mode (due to having an old local `plugin_platform_interface`. Now that everything has been updated, we can bump all the minimums so that people updating their plugins will get new versions of the dependency.
stuartmorgan
requested review from
bparrishMines,
cyanglaz and
ditman
as code owners
github-actions
bot
added
p: battery
ditman
approved these changes
Mar 1, 2021
| @@ -19,7 +19,7 @@ dev_dependencies: | |||
| sdk: flutter | |||
| pedantic: ^1.10.0 | |||
| mockito: ^5.0.0-nullsafety.7 | |||
| plugin_platform_interface: ">=1.0.0 <3.0.0" | |||
| plugin_platform_interface: ^2.0.0 | |||
There was a problem hiding this comment.
This is the odd-one out, for those looking to why a change that should have an even number of files changed has touched 35 files :P
|
LGTM! |
mvanbeusekom
approved these changes
Mar 1, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Mar 3, 2021
* master: Adopt Xcode 12 for podspec lints (flutter#3653) Run static analyzer during xctest (flutter#3667) [google_maps_flutter_web] update min flutter sdk version to 1.20.0 (flutter#3662) [image_picker] Run CocoaPods iOS tests in RunnerUITests target (flutter#3663) [webview_flutter] Run CocoaPods iOS tests in RunnerUITests target (flutter#3664) [device_info] Enable NNBD for unit test (flutter#3658) remove unused plugin (flutter#3661) [android_intent] move unit test to nullsafety (flutter#3659) [url_launcher] Migrate unit tests to NNBD (flutter#3657) [share] Migrate unit tests to null-safety. (flutter#3660) [connectivity_for_web] Migration to null-safety. (flutter#3652) [camera] Stable release for null safety. (flutter#3641) [in_app_purchase] fix plugin version (flutter#3654) Move plugin tool tests over (flutter#3606) [in_app_purchase] migrate playing billing library to v3 (flutter#3636) Update plugin_platform_interface min version (flutter#3650) # Conflicts: # packages/webview_flutter/CHANGELOG.md # packages/webview_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid intra-repo plugin conflicts during the NNBD stable migration,
plugin_platform_interfaceallowed either 1.x or 2.0. However, 1.0.xisn't null-safe so this can cause apps that don't have all their
packages fully updated can fail to run in strong mode (due to having an
old local
plugin_platform_interface).Now that everything has been updated, we can bump all the minimums so
that people updating their plugins will get new versions of the
dependency.