Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[device_info] Enable NNBD for unit test #3658

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[device_info] Enable NNBD for unit test #3658

merged 1 commit into from
Mar 2, 2021

Conversation

stuartmorgan
Copy link
Contributor

Removes the opt-out now that the underlying issue is fixed

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@stuartmorgan
[device_info] Enable NNBD for unit test
83af9ef 
Removes the opt-out now that the underlying issue is fixed
@google-cla google-cla bot added the cla: yes label Mar 2, 2021
cyanglaz
cyanglaz approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 2, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite submit-queue has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 2, 2021
@stuartmorgan
Copy link
Contributor Author

CQ redness is just the infra network flake.

@stuartmorgan stuartmorgan merged commit 1e3a823 into flutter:master Mar 2, 2021
@stuartmorgan stuartmorgan deleted the device-info-nnbd-unittest branch March 2, 2021 22:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2021
@engine-flutter-autoroll
1e3a823 [device_info] Enable NNBD for unit test (flutter/plugins#3658)
2a60e59
NickalasB added a commit to NickalasB/plugins that referenced this pull request Mar 3, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
a0e64b5 
* master:
  Adopt Xcode 12 for podspec lints (flutter#3653)
  Run static analyzer during xctest (flutter#3667)
  [google_maps_flutter_web] update min flutter sdk version to 1.20.0 (flutter#3662)
  [image_picker] Run CocoaPods iOS tests in RunnerUITests target (flutter#3663)
  [webview_flutter] Run CocoaPods iOS tests in RunnerUITests target (flutter#3664)
  [device_info] Enable NNBD for unit test (flutter#3658)
  remove unused plugin (flutter#3661)
  [android_intent] move unit test to nullsafety (flutter#3659)
  [url_launcher] Migrate unit tests to NNBD (flutter#3657)
  [share] Migrate unit tests to null-safety. (flutter#3660)
  [connectivity_for_web] Migration to null-safety. (flutter#3652)
  [camera] Stable release for null safety. (flutter#3641)
  [in_app_purchase] fix plugin version (flutter#3654)
  Move plugin tool tests over (flutter#3606)
  [in_app_purchase] migrate playing billing library to v3 (flutter#3636)
  Update plugin_platform_interface min version (flutter#3650)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes p: device_info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan @fluttergithubbot @cyanglaz