Bring HTML inputs into view automatically #3655
Conversation
github-actions
bot
added
p: webview_flutter
There was a problem hiding this comment.
WebView doesn't have Junit tests, unfortunately. I think we should clean up webview, and add platform tests similar to how we did in ads.
How hard is wiring up unit tests in Java? Obviously backfill is a major project, but can we add unit tests of just this piece now, so we're heading in the right direction?
| @@ -109,6 +109,7 @@ class SurfaceAndroidWebView extends AndroidWebView { | |||
| layoutDirection: TextDirection.rtl, | |||
| creationParams: MethodChannelWebViewPlatform.creationParamsToMap( | |||
| creationParams, | |||
| usesHybridComposition: true, | |||
There was a problem hiding this comment.
We should test that creating a SurfaceAndroidWebView sets this in the method channel to ensure the Dart side of this stays working.
There was a problem hiding this comment.
I ended up adding an e2e test. :)
There was a problem hiding this comment.
We still really need a unit test harness for this package, but I'll take it :)
blasten
force-pushed
the
webview_input
branch
2 times, most recently
from
19be29c
to
d22a16f
Compare
blasten
force-pushed
the
webview_input
branch
4 times, most recently
from
696ebe3
to
cf56c57
Compare
|
The failure in the CI doesn't make sense. The test is skipped, but somehow it appears to be running on iOS. I'm not sure how this is possible. |
* master: [google_sign_in] fix test(flutter#3690) [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689) [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686) Import flutter_test for future compatibility (flutter#3665) [ci] Disable analyze on stable for web plugins that contains null safety integration tests. (flutter#3681) Bring HTML inputs into view automatically (flutter#3655) [in_app_purchase] presentCodeRedemptionSheet (flutter#3274) [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679) Update CI config for Flutter 2 (flutter#3674) [image_picker] fix flutter/flutter#71927 (flutter#3676) [google_maps_flutter_web] Move integration tests to example. (flutter#3675) [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins (flutter#3673) # Conflicts: # packages/webview_flutter/CHANGELOG.md
Fixes flutter/flutter#75667
The inputs are hidden because
InputAwareWebViewmanages focus within the webview. This extension was added to workaround edge cases with virtual displays, but those are solved in the hybrid composition implementation.WebView doesn't have Junit tests, unfortunately. I think we should clean up webview, and add platform tests similar to how we did in ads.