Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] fix flutter/flutter#71927 #3676

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[image_picker] fix flutter/flutter#71927 #3676

merged 1 commit into from
Mar 4, 2021

Conversation

daadu
Copy link
Contributor

@daadu daadu commented Mar 4, 2021 •
edited
Loading

Removed otherElements reference that was waiting to be removed in XCUITests.

Closes flutter/flutter#71927

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@daadu daadu requested a review from cyanglaz as a code owner March 4, 2021 06:40
@google-cla google-cla bot added the cla: yes label Mar 4, 2021
@daadu
Copy link
Contributor Author

daadu commented Mar 4, 2021

@cyanglaz Will bump vesrion and changelong once you approve the change.

cyanglaz
cyanglaz approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!
It is not necessary to bump the version as this change only removes obsolete tests, which doesn't affect the plugin code.

@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 4, 2021
@fluttergithubbot fluttergithubbot merged commit 2518218 into flutter:master Mar 4, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
2518218 [image_picker] fix flutter#71927 (flutter/plugins#3676)
94b211b
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
2518218 [image_picker] fix #71927 (flutter/plugins#3676) (#77269)
9397c37
NickalasB added a commit to NickalasB/plugins that referenced this pull request Mar 8, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
fc41c1e 
* master:
  [google_sign_in] fix test(flutter#3690)
  [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689)
  [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686)
  Import flutter_test for future compatibility (flutter#3665)
  [ci] Disable analyze on stable for web plugins that contains null safety integration tests.  (flutter#3681)
  Bring HTML inputs into view automatically (flutter#3655)
  [in_app_purchase] presentCodeRedemptionSheet (flutter#3274)
  [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679)
  Update CI config for Flutter 2 (flutter#3674)
  [image_picker] fix flutter/flutter#71927 (flutter#3676)
  [google_maps_flutter_web] Move integration tests to example. (flutter#3675)
  [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins  (flutter#3673)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes p: image_picker platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[image_picker] Remove the otherElement check for static text in XCUITests
3 participants
@daadu @cyanglaz @fluttergithubbot