Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player]Update README.me #3713

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Conversation

trueshail
Copy link
Contributor

@trueshail trueshail commented Mar 14, 2021

  • Reflecting the updating API for checking the controller is Initialized

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Closes flutter/flutter#79178

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

- Reflecting the updating API for checking the controller is Initialized
@google-cla
Copy link

google-cla bot commented Mar 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 14, 2021
@trueshail
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 14, 2021
@trueshail trueshail changed the title Update README.me [video_player]Update README.me Mar 14, 2021
@stuartmorgan
Copy link
Contributor

Thanks for the contribution! Could you please update the version and CHANGELOG? That's necessary for publishing the change, and the published version of the README is the one most developers will interact with.

You'll also need to merge in the latest master to get the fix for the Linux CI failure.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a version bump; LGTM.

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 1, 2021
@fluttergithubbot fluttergithubbot merged commit 8531d56 into flutter:master Apr 1, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Apr 1, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: video_player waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

video_player api documentation 'initialized' to 'isInitailized'
3 participants