Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Fix small error in example #3743

Closed
wants to merge 1 commit into from

Conversation

ndahlquist
Copy link

@ndahlquist ndahlquist commented Mar 23, 2021

VideoPlayerValue does not have an initialized property. The correct property is isInitialized

Test Plan

  • Copy the example code into a Flutter project, verify it compiles and runs correctly.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

`VideoPlayerValue` does not have an `initialized` property. The correct property is `isInitialized`
@google-cla
Copy link

google-cla bot commented Mar 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ndahlquist
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 23, 2021
@ndahlquist ndahlquist changed the title Fix small error in video_player example [video_player] Fix small error in example Mar 23, 2021
@stuartmorgan
Copy link
Contributor

Thanks for the contribution, but this is already being fixed in #3713, so I'm going to close this in favor of continuing with that PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants