Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Revert "[camera] Add ability to concurrently record and stream video" #6796

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Dec 6, 2022

Reverts #6290

We forgot to run the Android FTL tests before landing; they don't run for non-team contributions, unfortunately. They are failing recording with image stream:

java.lang.Exception: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following PlatformException was thrown running a test:
PlatformException(error, stop failed., null,
java.lang.RuntimeException: stop failed.
at android.media.MediaRecorder.stop(Native Method)
at
io.flutter.plugins.camera.Camera.stopVideoRecording(Camera.java:779)
at
io.flutter.plugins.camera.MethodCallHandlerImpl.onMethodCall(MethodCallHandlerImpl.java:129)
at
io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:262)
at
io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)
at
io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$DartMessenger(DartMessenger.java:319)
at
io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown
Source:12)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:223)
at android.app.ActivityThread.main(ActivityThread.java:7664)
at java.lang.reflect.Method.invoke(Native Method)
at
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
)
When the exception was thrown, this was the stack:
#0 StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:653:7)
#1 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:296:18)
<asynchronous suspension>
#2 AndroidCamera.stopVideoRecording (package:camera_android/src/android_camera.dart:274:26)
<asynchronous suspension>
#3 CameraController.stopVideoRecording (package:camera_example/camera_controller.dart:330:9)
<asynchronous suspension>
#4 main.<anonymous closure> (file:///tmp/cirrus-ci-build/packages/camera/camera_android/example/integration_test/camera_test.dart:282:7)
<asynchronous suspension>
#5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:171:15)
<asynchronous suspension>
#6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:841:5)
<asynchronous suspension>
The test description was:
recording with image stream
═════════════════════════════════════════════════════════════════
at dev.flutter.plugins.integration_test.FlutterTestRunner.run(FlutterTestRunner.java:81)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:392)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2205)

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this mean we need to run the integration tests locally before submitting non-team contributions?

@stuartmorgan
Copy link
Contributor Author

Does this mean we need to run the integration tests locally before submitting non-team contributions?

What I've been doing (when I don't forget) is to push a trivial change to the PR, since that commit will be from a team member and thus run tests (but only for that one commit IIRC, not later commits).

Longer term we really need to do flutter/flutter#116597.

@stuartmorgan
Copy link
Contributor Author

Landing on red to fix the tree.

@stuartmorgan stuartmorgan merged commit 610370e into main Dec 6, 2022
@stuartmorgan stuartmorgan deleted the revert-6290-aharwood/enable_stream_and_record branch December 6, 2022 16:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 7, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 7, 2022
* 610370eb6 Revert "[camera] Add ability to concurrently record and stream video (#6290)" (flutter/plugins#6796)

* 36526ee23 [ci] Fix macOS LUCI merge base (flutter/plugins#6798)

* 7b5d8323e Roll Flutter from 30fc993 to e2fb672 (25 revisions) (flutter/plugins#6802)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…#116660)

* 610370eb6 Revert "[camera] Add ability to concurrently record and stream video (flutter#6290)" (flutter/plugins#6796)

* 36526ee23 [ci] Fix macOS LUCI merge base (flutter/plugins#6798)

* 7b5d8323e Roll Flutter from 30fc993 to e2fb672 (25 revisions) (flutter/plugins#6802)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants