This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Revert "[camera] Add ability to concurrently record and stream video" #6796
Merged
stuartmorgan
merged 1 commit into
main
from
revert-6290-aharwood/enable_stream_and_record
Dec 6, 2022
Merged
Revert "[camera] Add ability to concurrently record and stream video" #6796
stuartmorgan
merged 1 commit into
main
from
revert-6290-aharwood/enable_stream_and_record
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested review from
cbracken,
hellohuanlin,
camsim99,
ditman and
bparrishMines
as code owners
December 6, 2022 16:00
github-actions
bot
added
p: camera
platform-android
platform-ios
platform-web
platform-windows
labels
Dec 6, 2022
bparrishMines
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this mean we need to run the integration tests locally before submitting non-team contributions?
This was referenced Dec 6, 2022
ditman
approved these changes
Dec 6, 2022
What I've been doing (when I don't forget) is to push a trivial change to the PR, since that commit will be from a team member and thus run tests (but only for that one commit IIRC, not later commits). Longer term we really need to do flutter/flutter#116597. |
Landing on red to fix the tree. |
stuartmorgan
deleted the
revert-6290-aharwood/enable_stream_and_record
branch
December 6, 2022 16:10
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 7, 2022
* 610370eb6 Revert "[camera] Add ability to concurrently record and stream video (#6290)" (flutter/plugins#6796) * 36526ee23 [ci] Fix macOS LUCI merge base (flutter/plugins#6798) * 7b5d8323e Roll Flutter from 30fc993 to e2fb672 (25 revisions) (flutter/plugins#6802)
11 tasks
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#116660) * 610370eb6 Revert "[camera] Add ability to concurrently record and stream video (flutter#6290)" (flutter/plugins#6796) * 36526ee23 [ci] Fix macOS LUCI merge base (flutter/plugins#6798) * 7b5d8323e Roll Flutter from 30fc993 to e2fb672 (25 revisions) (flutter/plugins#6802)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…lutter#6290)" (flutter#6796) This reverts commit 374e598.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6290
We forgot to run the Android FTL tests before landing; they don't run for non-team contributions, unfortunately. They are failing
recording with image stream
: