This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Re-enable ability to concurrently record and stream video #6808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2022 10:18
This re-commits the content from flutter#6290. Will make a subsequent commit to try and fix the broken integ tests.
The `whenComplete` call was sometimes causing a race condition. It is also isn't needed for the test (to reset the value of isDetecting, given it's local), so removing it makes the test reliable.
adam-harwood
requested review from
cbracken,
hellohuanlin,
camsim99,
ditman and
bparrishMines
as code owners
github-actions
bot
added
p: camera
platform-android
platform-ios
platform-web
platform-windows
labels
11 tasks
|
See this comment for more context on this PR. CC @stuartmorgan |
hellohuanlin
approved these changes
Dec 8, 2022
|
There was a Looks like the Android tests are passing! |
stuartmorgan
approved these changes
Dec 8, 2022
stuartmorgan
added
the
autosubmit
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 9, 2022
* 929c9a632 [camera] Re-enable ability to concurrently record and stream video (flutter/plugins#6808) * f31a438f3 [video_player] Fix file URI construction (flutter/plugins#6803) * 6ab7d710d Roll Flutter from a570fd2 to 521028c (11 revisions) (flutter/plugins#6810)
packages/camera/camera_android/example/integration_test/camera_test.dart
Show resolved
Hide resolved
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#116781) * 929c9a632 [camera] Re-enable ability to concurrently record and stream video (flutter/plugins#6808) * f31a438f3 [video_player] Fix file URI construction (flutter/plugins#6803) * 6ab7d710d Roll Flutter from a570fd2 to 521028c (11 revisions) (flutter/plugins#6810)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…lutter#6808) * Re-enable stream and record This re-commits the content from flutter#6290. Will make a subsequent commit to try and fix the broken integ tests. * Fix broken integration test for streaming The `whenComplete` call was sometimes causing a race condition. It is also isn't needed for the test (to reset the value of isDetecting, given it's local), so removing it makes the test reliable. * Trivial CHANGELOG change to trigger full CI tests Co-authored-by: stuartmorgan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the functionality from #6290, which was reverted in #6796 due to a broken test. This PR will attempt to fix the integration test.
Closes flutter/flutter#83634
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).