This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camerax] Adds functionality to bind UseCases to a lifecycle #6939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +63,11 @@ public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) { | |||
|
|
|||
| @Override | |||
| public void onAttachedToActivity(@NonNull ActivityPluginBinding activityPluginBinding) { | |||
| updateContext(activityPluginBinding.getActivity()); | |||
| CameraAndroidCameraxPlugin plugin = new CameraAndroidCameraxPlugin(); | |||
There was a problem hiding this comment.
I think I missed this in the last PR. But I don't think it is necessary to create a new CameraAndroidCameraxPlugin instance. You should be able to just call setUp on the current instance, right?
| @NonNull Long cameraSelectorIdentifier, | ||
| @NonNull List<Long> useCaseIds) { | ||
| ProcessCameraProvider processCameraProvider = | ||
| (ProcessCameraProvider) instanceManager.getInstance(identifier); |
There was a problem hiding this comment.
Could you wrap instanceManager.getInstance(..) with Objects.requireNonnull(...). It helps with debugging and removes the lint warning. Same for the line below and other apis.
There was a problem hiding this comment.
cc @gmackall just a heads up about this
...mera/camera_android_camerax/android/src/test/java/io/flutter/plugins/camerax/CameraTest.java
Outdated
Show resolved
Hide resolved
...mera/camera_android_camerax/android/src/test/java/io/flutter/plugins/camerax/CameraTest.java
Show resolved
Hide resolved
| ProcessCameraProvider instance) async { | ||
| /// Gets identifier that the [instanceManager] has set for | ||
| /// the [ProcessCameraProvider] instance. | ||
| int getProcessCameraProviderIdentifier(ProcessCameraProvider instance) { | ||
| int? identifier = instanceManager.getIdentifier(instance); | ||
| identifier ??= instanceManager.addDartCreatedInstance(instance, |
There was a problem hiding this comment.
Why does this add the instance to the InstanceManager if it doesn't contain the ProcessCameraProvider.?Shouldn't getInstancefromInstances add the ProcessCameraProvider to the InstanceManager? This should throw an error if the InstanceManager doesn't contain instance.
There was a problem hiding this comment.
I agree. Fixed that.
bparrishMines
approved these changes
Jan 25, 2023
...oid_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraAndroidCameraxPlugin.java
Outdated
Show resolved
Hide resolved
...merax/android/src/main/java/io/flutter/plugins/camerax/ProcessCameraProviderHostApiImpl.java
Outdated
Show resolved
Hide resolved
11 tasks
…o/flutter/plugins/camerax/ProcessCameraProviderHostApiImpl.java Co-authored-by: Maurice Parrish <[email protected]>
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2023
* bc0174fd5 [path_provider] Fix iOS `getApplicationSupportDirectory` regression (flutter/plugins#7026) * 15d799b89 [url_launcher] Convert Windows to Pigeon (flutter/plugins#6991) * dc8ad7701 Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter/plugins#7025) * e9406bc20 [camerax] Adds functionality to bind UseCases to a lifecycle (flutter/plugins#6939)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
UseCaseandCameraclasses and adds methods in theProcessCameraProviderclass to allow for the binding ofUseCases to the lifecycle of aCamera.Fixes flutter/flutter#111220.
Part of flutter/flutter#111127, flutter/flutter#115846.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.