This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Convert Windows to Pigeon #6991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
commented
Jan 19, 2023
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
| // Autogenerated from Pigeon (v5.0.1), do not edit directly. |
There was a problem hiding this comment.
You're welcome to review the *.g.* files if you want to provide feedback on Pigeon's output, which I can turn into Pigeon issues, but you can also skip it if you want since it's purely generated code.
packages/url_launcher/url_launcher_windows/windows/url_launcher_plugin.h
Show resolved
Hide resolved
packages/url_launcher/url_launcher_windows/windows/test/url_launcher_windows_test.cpp
Show resolved
Hide resolved
cbracken
approved these changes
Jan 24, 2023
packages/url_launcher/url_launcher_windows/test/url_launcher_windows_test.dart
Outdated
Show resolved
Hide resolved
stuartmorgan
added
the
autosubmit
|
auto label is removed for flutter/plugins, pr: 6991, Failed to merge pr#: 6991 with Pull request could not be merged: Pull Request is not mergeable. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan
added
the
autosubmit
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* Initial definition matching current API * Rename, autoformat * Update native implementation and unit tests * Update Dart; remove unnecessary Pigeon test API * Version bump * autoformat * Adjust mock API setup * Improve comment
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2023
* bc0174fd5 [path_provider] Fix iOS `getApplicationSupportDirectory` regression (flutter/plugins#7026) * 15d799b89 [url_launcher] Convert Windows to Pigeon (flutter/plugins#6991) * dc8ad7701 Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter/plugins#7025) * e9406bc20 [camerax] Adds functionality to bind UseCases to a lifecycle (flutter/plugins#6939)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the manual method channel code with Pigeon.
To minimize changes in this PR, this keeps the same API boundary, without moving any logic from C++ to Dart; there's definitely opportunity to do some of that as a follow-up (e.g., moving scheme extraction to Dart and replacing
canLaunchUrlwithhasSchemeHandler). However, the API—and thus tests—are simplified because the current method channel API was the result of copying the old shared method channel API during the move away from shared method channels, so contained a lot of parameters that are unused on Windows.Part of flutter/flutter#117915
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).