iOS delegate and some features #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add eval javascript sink onUrlChanged ...
fix document
android: add rect, fullScreen, userAgent, eval
ios and android more implement
|
looks nicer ^^, sorry December is a busy month, I will try to take care of this today |
lejard-h
requested changes
Dec 18, 2017
There was a problem hiding this comment.
Awesome,
I commented for a small change,
It works great on iOS, but I have some errors on Android :
PlatformException(error, Attempt to invoke virtual method 'void android.view.ViewGroup.removeView(android.view.View)' on a null object reference, null)
[ ] E/flutter ( 4016): #0 StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:514)
[ ] E/flutter ( 4016): #1 MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:154)
[ ] E/flutter ( 4016): <asynchronous suspension>
[ ] E/flutter ( 4016): #2 FlutterWebViewPlugin.close (package:flutter_webview_plugin/flutter_webview_plugin.dart:140)
I have this exception when I try to close a hidden wehbview, and for a fullscreen view the back navigation is broken.
You can add you name to the pubspec and update the version to 0.0.10, you can also update the CHANGELOG, great work thanks.
Tell me if you prefer to merge this, I can take care of the Android part.
example/lib/main.dart
Outdated
|
|
||
| // On destroy stream | ||
| StreamSubscription _onDestroy; | ||
|
|
||
| // On urlChanged stream | ||
| StreamSubscription<String> _onUrlChanged; | ||
|
|
||
| TextEditingController _ctrl = | ||
| new TextEditingController(text: "https://flutter.io"); | ||
| StreamSubscription<String> _onStateChanged; |
There was a problem hiding this comment.
you should cancel the subscription
ready to 0.0.10
charafau
pushed a commit
that referenced
this pull request
Apr 7, 2020
iOS delegate and some features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS:
iOS/Android:
Add document for argument.