Merge pull request #186 from yurymuski/main

flux2-notification: fix provider template
fluxcd-community · Sep 13, 2023 · 8e73e5d · 8e73e5d
2 parents b7dec7f + 4a9c053
commit 8e73e5d
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/charts/flux2-notification/Chart.yaml b/charts/flux2-notification/Chart.yaml
@@ -1,11 +1,11 @@
 apiVersion: v2
 name: flux2-notification
 type: application
-version: 1.11.0
+version: 1.12.0
 appVersion: 2.1.0
 description: A Helm chart for flux2 alerts and the needed providers and secrets
 sources:
   - https://github.com/fluxcd-community/helm-charts
 annotations:
   artifacthub.io/changes: |
-    - "[Chore]: Update App Version to upstream 2.1.0"
+    - "[Chore]: fix provider template"
diff --git a/charts/flux2-notification/README.md b/charts/flux2-notification/README.md
@@ -1,6 +1,6 @@
 # flux2-notification
 
-![Version: 1.11.0](https://img.shields.io/badge/Version-1.11.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.1.0](https://img.shields.io/badge/AppVersion-2.1.0-informational?style=flat-square)
+![Version: 1.12.0](https://img.shields.io/badge/Version-1.12.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.1.0](https://img.shields.io/badge/AppVersion-2.1.0-informational?style=flat-square)
 
 A Helm chart for flux2 alerts and the needed providers and secrets
 
@@ -16,4 +16,4 @@ This helm chart is maintain and released by the fluxcd-community on a best effor
 |-----|------|---------|-------------|
 | alertlist | list | `[]` | A list of alerts to be used. See values.yaml for example |
 | providerlist | list | `[]` | A list of providers to be used. See values.yaml for example |
-| secretlist | list | `[]` | A list of secrets to be used. See values.yaml for example For help see: https://fluxcd.io/docs/components/notification/provider/ |
+| secretlist | list | `[]` | A list of secrets to be used. See values.yaml for example For help see: https://fluxcd.io/flux/components/notification/providers/ |
diff --git a/charts/flux2-notification/templates/provider.yaml b/charts/flux2-notification/templates/provider.yaml
@@ -26,11 +26,11 @@ spec:
   {{- if $provider.spec.proxy }}
   proxy: "{{ $provider.spec.proxy }}"
   {{- end }}
-  {{- if $provider.spec.secretRef.name }}
+  {{- if $provider.spec.secretRef }}
   secretRef:
     name: {{ $provider.spec.secretRef.name }}
   {{- end }}
-  {{- if $provider.spec.certSecretRef.name }}
+  {{- if $provider.spec.certSecretRef }}
   certSecretRef:
     name: {{ $provider.spec.certSecretRef.name }}
   {{- end }}

diff --git a/charts/flux2-notification/tests/__snapshot__/alert_test.yaml.snap b/charts/flux2-notification/tests/__snapshot__/alert_test.yaml.snap
@@ -8,7 +8,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/part-of: flux
         app.kubernetes.io/version: 2.1.0
-        helm.sh/chart: flux2-notification-1.11.0
+        helm.sh/chart: flux2-notification-1.12.0
       name: all-kustomizations
       namespace: NAMESPACE
     spec:

diff --git a/charts/flux2-notification/tests/__snapshot__/provider_test.yaml.snap b/charts/flux2-notification/tests/__snapshot__/provider_test.yaml.snap
@@ -8,7 +8,7 @@ should match snapshot:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/part-of: flux
         app.kubernetes.io/version: 2.1.0
-        helm.sh/chart: flux2-notification-1.11.0
+        helm.sh/chart: flux2-notification-1.12.0
       name: on-call-slack
       namespace: NAMESPACE
     spec:

diff --git a/charts/flux2-notification/tests/__snapshot__/secret_test.yaml.snap b/charts/flux2-notification/tests/__snapshot__/secret_test.yaml.snap
@@ -8,7 +8,7 @@ should match snapshot of default values:
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/part-of: flux
         app.kubernetes.io/version: 2.1.0
-        helm.sh/chart: flux2-notification-1.11.0
+        helm.sh/chart: flux2-notification-1.12.0
       name: webhook-url
       namespace: NAMESPACE
     stringData:

diff --git a/charts/flux2-notification/values.yaml b/charts/flux2-notification/values.yaml
@@ -1,5 +1,5 @@
 # -- A list of secrets to be used. See values.yaml for example
-# For help see: https://fluxcd.io/docs/components/notification/provider/
+# For help see: https://fluxcd.io/flux/components/notification/providers/
 secretlist: []
   # - name: webhook-url
   #   value: