Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux2-notification: fix provider template #186

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

yurymuski
Copy link
Contributor

@yurymuski yurymuski commented Sep 12, 2023

Which issue this PR fixes

fix: #178

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested
  • Update artifacthub.io/changes in Chart.yaml
  • Run make reviewable

Signed-off-by: yurymuski <[email protected]>
@yurymuski
Copy link
Contributor Author

seems you are using old version of helm-unit tests, new one does not know about --helm3 flag, and requires indentation changes

pushed commit w/o indentation changes

@stefanprodan
Copy link
Member

@yurymuski could you please update helm-test in a different PR?

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @yurymuski 🏅

@stefanprodan stefanprodan merged commit 8e73e5d into fluxcd-community:main Sep 13, 2023
4 checks passed
@yurymuski
Copy link
Contributor Author

@stefanprodan sure, I can update tests, will add it todo list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fluxv2-notification schema issue
2 participants