Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/int: IAM CI setup docs & exit code propagation #423

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

darkowlzz
Copy link
Contributor

Add terraform config in the docs for creating IAM permissions and populating github actions secrets and variables required by the integration tests.

Also, update the test runner to propagate the exit code always. This is based on observations while testing flux2 e2e tests that the exit code didn't surface in certain situations.

Similar to fluxcd/pkg#607.

@darkowlzz darkowlzz added the area/testing Testing related issues and pull requests label Jul 21, 2023
Add terraform config in the docs for creating IAM permissions and
populating github actions secrets and variables required by the
integration tests.

Also, update the ACR configuration to enable admin user. This is
required for service principal created using terraform. Service
principal created by azure portal don't need this.

Signed-off-by: Sunny <[email protected]>
Copy link
Member

@somtochiama somtochiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks Sunny

@darkowlzz darkowlzz merged commit 3549296 into main Jul 21, 2023
@darkowlzz darkowlzz deleted the test-ci-setup-automation branch July 21, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants