oci/tests/int: IAM setup automation docs & exit code propagation #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Jul 18, 2023
darkowlzz
force-pushed
the
oci-test-ci-setup-docs
branch
2 times, most recently
from
52a36e8
to
795d30f
Compare
darkowlzz
changed the title
darkowlzz
force-pushed
the
oci-test-ci-setup-docs
branch
4 times, most recently
from
f39a370
to
195404d
Compare
Add terraform config in the docs for creating IAM permissions and populating github actions secrets and variables required by the integration tests. Also, update the ACR configuration to enable admin user. This is required for service principal created using terraform. Service principal created by azure portal don't need this. Signed-off-by: Sunny <[email protected]>
Signed-off-by: Sunny <[email protected]>
darkowlzz
force-pushed
the
oci-test-ci-setup-docs
branch
from
195404d
to
524494d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add terraform config in the docs for creating IAM permissions and populating github actions secrets and variables required by the integration tests.
This is based on:
Also, update the test runner to propagate the exit code always. This is based on observations while testing flux2 e2e tests that the exit code didn't surface in certain situations.