Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate double copying in vformat_to_n #2489

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

Roman-Koshelev
Copy link
Contributor

format_to_n () may not be slower than format_to(). To do this, we will format immediately into the resulting buffer (until it ends)

@vitaut
Copy link
Contributor

vitaut commented Sep 7, 2021

Thanks for the PR. I think this should be merged into the main iterator_buffer template since it's almost identical.

@Roman-Koshelev
Copy link
Contributor Author

At first glance, yes, that's what I wrote. But it seemed to me that it is easier to take out into a separate class than to fence all in one

@vitaut
Copy link
Contributor

vitaut commented Sep 7, 2021

OK, let's keep it as a separate specialization.

@vitaut vitaut merged commit 1aa98f8 into fmtlib:master Sep 9, 2021
@vitaut
Copy link
Contributor

vitaut commented Sep 9, 2021

Thank you!

PoetaKodu pushed a commit to pacc-repo/fmt that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants