Skip to content

Commit

Permalink
Eliminate double copying in vformat_to_n (fmtlib#2489)
Browse files Browse the repository at this point in the history
  • Loading branch information
Roman-Koshelev authored and PoetaKodu committed Nov 11, 2021
1 parent 4fad7bf commit 5aed669
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions include/fmt/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,46 @@ class iterator_buffer final : public Traits, public buffer<T> {
auto count() const -> size_t { return Traits::count() + this->size(); }
};

template <typename T>
class iterator_buffer<T*, T, fixed_buffer_traits> final : public fixed_buffer_traits, public buffer<T> {
private:
T* out_;
enum { buffer_size = 256 };
T data_[buffer_size];

protected:
void grow(size_t) override {
if (this->size() == this->capacity()) flush();
}

void flush() {
size_t n = this->limit(this->size());
if (this->data() == out_) {
out_ += n;
this->set(data_, buffer_size);
}
this->clear();
}

public:
explicit iterator_buffer(T* out, size_t n = buffer_size)
: fixed_buffer_traits(n), buffer<T>(out, 0, n), out_(out) {}
iterator_buffer(iterator_buffer&& other)
: fixed_buffer_traits(other), buffer<T>(std::move(other)), out_(other.out_) {
if (this->data() != out_) {
this->set(data_, buffer_size);
this->clear();
}
}
~iterator_buffer() { flush(); }

auto out() -> T* {
flush();
return out_;
}
auto count() const -> size_t { return fixed_buffer_traits::count() + this->size(); }
};

template <typename T> class iterator_buffer<T*, T> final : public buffer<T> {
protected:
void grow(size_t) override {}
Expand Down

0 comments on commit 5aed669

Please sign in to comment.