Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings on gcc and clang #681

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Fix warnings on gcc and clang #681

merged 2 commits into from
Mar 15, 2018

Conversation

eliaskosunen
Copy link
Contributor

@eliaskosunen eliaskosunen commented Mar 15, 2018 •
edited
Loading

First commit fixes a -Wpedantic warning when compiling with gcc and clang.
Second commit defines FMT_UNION as union rather than struct on clang.

@eliaskosunen eliaskosunen changed the title Remove extra semicolon in format_args constructor Fix warnings on gcc and clang Mar 15, 2018
@vitaut vitaut merged commit 10b939b into fmtlib:master Mar 15, 2018
@vitaut
Copy link
Contributor

vitaut commented Mar 15, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliaskosunen @vitaut