Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings on gcc and clang #681

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Fix warnings on gcc and clang #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2144be
Remove extra semicolon in format_args constructor
eliaskosunen Mar 15, 2018
61cc01f
Remove unneeded usage of anonymous struct on clang
eliaskosunen Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fmt/core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,7 @@ class basic_format_args {
struct format_args: basic_format_args<context> {
template <typename ...Args>
format_args(Args && ... arg)
: basic_format_args<context>(std::forward<Args>(arg)...) {};
: basic_format_args<context>(std::forward<Args>(arg)...) {}
};
typedef basic_format_args<wcontext> wformat_args;

Expand Down
2 changes: 1 addition & 1 deletion include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
#endif

// A workaround for gcc 4.4 that doesn't support union members with ctors.
#if FMT_GCC_VERSION && FMT_GCC_VERSION <= 404
#if (FMT_GCC_VERSION && FMT_GCC_VERSION <= 404) && !defined(__clang__)
# define FMT_UNION struct
#else
# define FMT_UNION union
Expand Down