Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] - Using allowMultiple = true #284

Closed
ibelar opened this issue Dec 3, 2018 · 0 comments
Closed

[Modal] - Using allowMultiple = true #284

ibelar opened this issue Dec 3, 2018 · 0 comments
Assignees
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@ibelar
Copy link

ibelar commented Dec 3, 2018

Bug Report

Closing Modal, when allowMultiple is set to true, via the Dimmer area of the page will close Modal even if onHide callback return false.

Steps to reproduce

  1. Create Modals with allowMultiple = true;
  2. Create onHide callback that return false;
  3. Open first modal and click dimmer area to close modal

Expected result

onHide return false should prevent modal from closing.

Actual result

onHide is called but Modal still close.
Modal does not reopen after.

Testcase

https://jsfiddle.net/ibelar/h8a3se4o/

Version

2.6.4

@lubber-de lubber-de self-assigned this Dec 4, 2018
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript labels Dec 4, 2018
y0hami pushed a commit that referenced this issue Dec 6, 2018
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 6, 2018
@lubber-de lubber-de added this to the 2.7.0 milestone Dec 6, 2018
y0hami pushed a commit that referenced this issue Dec 18, 2018
This was referenced Dec 21, 2018
@y0hami y0hami closed this as completed in 9faccb7 Dec 21, 2018
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants