[Modal] Dimmer-Click closed Modal when allowMultiple=true even if onHide()=false

[lubber-de]

Description

Trying to close a modal by clicking in the dimmer area but having return false at the onHide-Method did still close the modal if allowMultiple was set to true

Testcase

Unfixed

https://jsfiddle.net/ibelar/h8a3se4o/

Fixed

https://jsfiddle.net/bagwd05n/

Closes

#215
#284

[prudho]

Modal event onHide seem to be triggered multiple times the second time you open the modal.

[lubber-de]

You mean when clicking on the button within the first modal after opening the first (just because the fiddle does not allow to close any modal when it is openened once) ? Then it's wanted behavior because the onhide is called for each opened modal when clicking on the dimmer. The fiddle defines the onhide method globally in the modals prototype so it is assigned to every modal

[prudho]

I have set return true in the onHide callback.

[lubber-de]

😱 You are right, something is wrong with the attached events... i'll take care of it. Thanks for finding it out

[lubber-de]

@prudho I fixed it now, was quite nasty. It was indeed totally bugged when using multiple modals, because the return false of onHide was not respected within the loop in hideAll ... Anyway, please review again, the jsfiddle from above should have been automatically updated by the included link to modal.js the latest repo-branch.
Please note: onHide (and so the alert) will be triggered for each open modal. So:

• onHide returns true and 2 modals are open -> 2 alerts will be shown
• onHide returns false and 2 modals are open -> only 1 alert is shown
• onHide returns true or false and 1 modal is open -> only 1 alert is shown

[lubber-de]

🙄 Also fixed dimmer-click now when allowMultiple=false and onHide return false...

[prudho]

LGTM

[y0hami]

LGTM