-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📎 Dynamic code hints: warn when creating a multiple definition #1859
base: main
Are you sure you want to change the base?
Conversation
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="warn-double-definitions")
julia> using Pluto |
Very cool! 🔥 warn-double-definitions...warn-double-definitions-codemirror-lint |
ayyy, it even knows about DataFrames! (just function calls in general?) using DataFrames
hello = 123
DataFrame(hello = rand(10)) # All good in the neighborhood although it will grumble while in the process of making a named tuple, but maybe that should be preferred? hmm-2022-01-28_16.41.29.mp4 |
Co-authored-by: Paul <[email protected]>
This is now merged! #1859 (comment) |
i am looking into overlaying the warning gutter with line numbers. (disabling 6892d7a in multiple definitions can be moved to another pr) |
frontend tests will give ✅ again if you update from |
Awesome work! This is great for people on a touch screen (can't hover) |
Wait...... did you just secretly fix #1386............ WOW Can you put that on |
Cool! What do you need from that PR? Or just avoiding merge conflicts |
Co-authored-by: Fons van der Plas <[email protected]>
973a5e0
to
048edb6
Compare
@Pangoraw can you move the backend changes to a new PR? Did you say that it has performance issues, or was that about something else? |
Schermopname.2022-01-27.om.00.59.24.mov
The warning system is more general, and can be used for other syntax-matching hints.
TODOs: