-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically disable older cells to solve multiple defs #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="auto-disable-multiple-definitions")
julia> using Pluto |
fonsp
added
backend
Concerning the julia server and runtime
reactivity
The Pluto programming paradigm
labels
Oct 5, 2022
Now with GUI! Schermopname.2022-10-14.om.19.39.58.mov |
rikhuijzer
reviewed
Oct 18, 2022
rikhuijzer
reviewed
Oct 18, 2022
rikhuijzer
reviewed
Oct 18, 2022
Co-authored-by: Rik Huijzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some extra code into
update_save_run!
that checks, by comparing the old and newTopology
s:cells
(i.e. cells that the user wants to run) define a variable that was defined a fewer number of times in the oldTopology
?cell
:a. Does
cell
define exactly one variable?b. Are all definers of that variable not in
cells
? i.e. did the other definitions appear in a previous run?c. Are no function definitions involved?
d. Are there no macro calls? (TODO)
e. Does
cell
not reference itself? (e.g.x = x+1
)f. Then: disable all other definers of the variable.
This is done fully in backend, which makes it accurate!
Demo
This video demonstrates the basic functionality, and then a series of situations where we purposefully do not use this new feature.
Schermopname.2022-10-07.om.17.07.27.mov
Previous/related work
NotebookTopology
#2270TODO
NotebookTopology
#2270x = x + 1
?