make Glyph.name optional for compatibilty with defcon #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make it easier to use ufoLib2 as drop-in replacement for defcon API. defcon.Glyph.name defaults to None, and it can't be set from init constructor.
… unique) the same Glyph object can't be added twice because the name attribute is also its key and it must be unique.
this copies and overwrites by default. addGlyph (unique to ufoLib2) does not copy and does not overwrite.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=========================================
+ Coverage 71.95% 75.36% +3.4%
=========================================
Files 19 19
Lines 1077 1108 +31
Branches 160 172 +12
=========================================
+ Hits 775 835 +60
+ Misses 258 230 -28
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
anthrotype
force-pushed
the
optional-glyph-name
branch
from
b02c391
to
9e8296e
Compare
madig
reviewed
Feb 20, 2020
madig
approved these changes
Feb 20, 2020
|
thanks! |
|
@typemytype do let us know if you find other API incompatibilities that we could fix, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as @typemytype wrote in googlefonts/ufo2ft#363 (comment)
this PR makes Glyph.name default to None (e.g. for Glyphs without a parent layer).
As soon as a name-less glyph is added to a Layer object, it gets a name defined by its key in the layer underlying dict.