Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Glyph.name optional for compatibilty with defcon #51

Merged
merged 5 commits into from
Feb 20, 2020
Merged

make Glyph.name optional for compatibilty with defcon #51

merged 5 commits into from
Feb 20, 2020

Commits on Feb 20, 2020

  1. Glyph: make 'name' parameter optional, default to None 

    This is to make it easier to use ufoLib2 as drop-in replacement for defcon API.
defcon.Glyph.name defaults to None, and it can't be set from init constructor.
    @anthrotype
    anthrotype committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    0fe354f View commit details
    Browse the repository at this point in the history

  2. Layer: allow to init new layer with name-less Glyphs (objects must be… 

    … unique)

the same Glyph object can't be added twice because the name attribute is also its key and it must be unique.
    @anthrotype
    anthrotype committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    b7cda66 View commit details
    Browse the repository at this point in the history

  3. Layer: add insertGlyph method like defcon's 

    this copies and overwrites by default.

addGlyph (unique to ufoLib2) does not copy and does not overwrite.
    @anthrotype
    anthrotype committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    b384713 View commit details
    Browse the repository at this point in the history

  4. Layer: add instantiateGlyphObject for compat with defcon 

    e.g. used in ufo2ft googlefonts/ufo2ft@2ea4041
    @anthrotype
    anthrotype committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    5c4f2c0 View commit details
    Browse the repository at this point in the history

  5. add tests for Layer constructor, insertGlyph, addGlyph, newGlyph, ren… 

    …ameGlyph
    @anthrotype
    anthrotype committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    9e8296e View commit details
    Browse the repository at this point in the history