fix: fixed for:each error on hover (#491)

* fix: fixed for:each error on hover Addressed an issue where a for:each was not available, and was causing an undefined error. vscode #3929 * feat: added unit test for case when t.classMembers is undefined Co-authored-by: Jeff Beeghly <[email protected]>
forcedotcom · Apr 4, 2022 · 6e8739d · 6e8739d
1 parent d37d48f
commit 6e8739d
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/packages/lwc-language-server/src/__tests__/lwc-data-provider.test.ts b/packages/lwc-language-server/src/__tests__/lwc-data-provider.test.ts
@@ -1,6 +1,8 @@
 import ComponentIndexer from '../component-indexer';
+import { ModuleExports, WireDecorator } from '../decorators';
+import { DataProviderAttributes, LWCDataProvider } from '../lwc-data-provider';
+import Tag, { TagAttrs } from '../tag';
 import * as path from 'path';
-import { LWCDataProvider, DataProviderAttributes } from '../lwc-data-provider';
 
 const workspaceRoot: string = path.resolve('../../test-workspaces/sfdx-workspace');
 const componentIndexer: ComponentIndexer = new ComponentIndexer({
@@ -24,6 +26,33 @@ describe('provideValues()', () => {
         expect(names).toInclude('info');
         expect(names).toInclude('iconName');
     });
+
+    it('should validate an empty array is returned when tag.classMembers is undefined', () => {
+        // The setting of the TagAttrs's file property needs to be delayed. It needs to be undefined
+        // when passed into the ctor(), and then we'll manually set it afterwards.
+        const tagAttrs: TagAttrs = {
+            file: undefined,
+            metadata: {
+                decorators: [] as WireDecorator[],
+                exports: [] as ModuleExports[],
+            },
+            updatedAt: undefined,
+        };
+        const tag = new Tag(tagAttrs);
+        tag.file = 'path/to/some-file';
+
+        const componentIndexer = new ComponentIndexer({
+            workspaceRoot,
+        });
+        componentIndexer.tags.set(tag.name, tag);
+
+        const provider = new LWCDataProvider({
+            indexer: componentIndexer,
+        });
+
+        const values = provider.provideValues();
+        expect(values).toEqual([]);
+    });
 });
 
 describe('provideAttributes()', () => {

diff --git a/packages/lwc-language-server/src/lwc-data-provider.ts b/packages/lwc-language-server/src/lwc-data-provider.ts
@@ -46,7 +46,7 @@ export class LWCDataProvider implements IHTMLDataProvider {
     provideValues(): IValueData[] {
         const values: IValueData[] = [];
         this.indexer.customData.forEach(t => {
-            t.classMembers.forEach(cm => {
+            t.classMembers?.forEach(cm => {
                 const bindName = `${t.name}.${cm.name}`;
                 values.push({ name: cm.name, description: `${bindName}` });
             });