fix: fixed for:each error on hover #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed an issue where a for:each was not available, and was causing an undefined error. vscode #3929
gbockus-sf
reviewed
Mar 22, 2022
| this.indexer.customData.forEach(t => { | ||
| t.classMembers.forEach(cm => { | ||
| this.indexer.customData?.forEach(t => { | ||
| t.classMembers?.forEach(cm => { |
There was a problem hiding this comment.
can we add a unit test for this condition? One to cover where customData isn't defined and one for when t.classMembers isn't defined?
There was a problem hiding this comment.
I knew you were gonna ask for it 😆
There was a problem hiding this comment.
I added a unit test for the case when t.classMembers is undefined.
For indexer.customData, indexer.customData() is a wrapper around ComponentIndexer.tags, and tags can never be null (in the body of the class, it's defined as readonly tags: Map<string, Tag> = new Map();).
randi274
commented
Mar 25, 2022
| @@ -116,7 +116,7 @@ it('transform throws exceptions on syntax errors', async () => { | |||
| // verify err has the info we need | |||
| const message = extractMessageFromBabelError(err.message); | |||
| expect(message).toMatch('Unexpected token (4:17)'); | |||
| expect(err.location).toEqual({ line: 4, column: 17 }); | |||
| expect(err.location).toEqual({ line: 4, column: 17, index: 110 }); | |||
There was a problem hiding this comment.
I'm not sure why this was failing, but the addition of the index is now expected here.
jeffb-sfdc
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addressed an issue where a for:each was not available, and was causing an undefined error.
To reproduce, hover over an item that doesn't have associated information with it, like the value of a for:each or a class name.
What issues does this PR fix or reference?
@W-10857157@, vscode #3929