fix(auth-server): handle preflight requests #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
previously approved these changes
Mar 21, 2024
cristiand391
commented
Mar 21, 2024
| public handlePreflightRequest(response: http.ServerResponse): void { | ||
| // We don't validate the origin here because: | ||
| // 1. The default login URL (login.salesforce.com) will not match after a redirect or if user choose a custom domain in login. | ||
| // 2. There's no fixed list of auth URLs we could check against. |
There was a problem hiding this comment.
point 1 refers to the oauth config object that can be accessed here.
If the value of the Origin header is not a case-sensitive match for any of the values in list of origins do not set any additional headers and terminate this set of steps.
Always matching is acceptable since the list of origins can be unbounded.
|
This issue has been linked to a new work item: W-15313611 |
QA Notes
✅ : able to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the auth web server to handle preflight requests.
Chrome v123 (promoted to stable 2 days ago) now does a preflight request (
OPTIONSreq) to the server before the auth request, the server only handledGETrequest and was throwing on anything else, blocking the web auth flow.repro:
sf org login web, type auth creds in browser and click on loginsfexits withInvalid request method: OPTIONSerror.on the network tab you can see the preflight request that causes the failure:
testing:
link this branch into plugin-auth and follow the repro steps, the preflight request is handled correctly and auth can follow.
What issues does this PR fix or reference?
@W-15313611@
forcedotcom/cli#2785