Fix error 'metaWindow.get_title is not a function' #344
Conversation
to make it easier to read
This was the cause of ghosts windows with dynamic workspaces: Closing a window in a workspace reduced the number of workspaces above it. Windows in these workspaces considered that there was still another window, and finished tiling with a ghost window.
|
Gentle ping @bennypowers @juarezr for the review. Except the variable renaming, the only change is https://github.com/forge-ext/forge/pull/344/files#diff-ecc5aba1b19feb12aedd8037846a95297082072be1a704814195edb468f846dfR1614-R1617 Once merge we can publish a new release :) |
| this.tree.removeNode(nodeWindow); | ||
| this.renderTree("window-destroy-quick", true); | ||
| this.removeFloatOverride(nodeWindow, false, true); | ||
| this.removeFloatOverride(nodeWindow.nodeValue, true); |
There was a problem hiding this comment.
Has the signature of this function changed it just the variable name?
There was a problem hiding this comment.
The signature of removeFloatOverride has been changed in another patch and hasn't been changed here
There was a problem hiding this comment.
Hey @bennypowers, do you have any concerns on the function signature change?
Hey @p1gp1g, I can update your role so you can merge. Just need someone to test looks OK or need evidence (screencap) that this is working fine.
There was a problem hiding this comment.
No the signature change doesn't bother me; it's just not immediately clear from this PR why this change was made here
If OP wants bonus marks, split that line into a separate commit with a detailed message
But that's not something which should hold up the merge.
If other reviewers have run this and found it acceptable, I'm good with it
There was a problem hiding this comment.
Alright, just found out that I can add per repository role maintain access to all of you in settings.
Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]>
|
No worries thanks @bennypowers. @p1gp1g - you might want to give it one more look from main. Then I can release over the weekend. Thank you for all your contributions |
This was the cause of ghosts windows with dynamic workspaces: Closing a window in a workspace reduced the number of workspaces above it. Windows in these workspaces considered that there was still another window, and finished tiling with a ghost window.
Error log: