Skip to content

Commit

Permalink
client: Use more specific page titles for password & opml
Browse files Browse the repository at this point in the history
  • Loading branch information
@jtojnar
jtojnar committed Oct 4, 2019
1 parent 1915a3e commit d39d550
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion assets/hashpassword.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="utf-8">

<title>selfoss</title>
<title>selfoss password hash generator</title>

<!-- Mobile viewport optimized: j.mp/bplateviewport -->
<meta name="viewport" content="width=device-width, user-scalable=yes, initial-scale=1" />
Expand Down
2 changes: 1 addition & 1 deletion assets/opml.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="utf-8">

<title>selfoss</title>
<title>selfoss OPML importer</title>

This comment has been minimized.

Sign in to view

Copy link
@akash07k

akash07k Oct 4, 2019

Contributor

So, here can't we retrieve the title from the configurations as before?

<!-- Mobile viewport optimized: j.mp/bplateviewport -->
<meta name="viewport" content="width=device-width, user-scalable=yes, initial-scale=1">
Expand Down

4 comments on commit d39d550

@jtojnar
Copy link
Member Author

@jtojnar jtojnar commented on d39d550 Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, unless we want to include the whole index.js into the OPML page. And then we would need to handle event handling in there. Hopefully we will move to React/Vue.js, which will allow us greater flexibility.

@akash07k
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, migrating to react or vue.js is a great idea. is working going on in that direction also?

@jtojnar
Copy link
Member Author

@jtojnar jtojnar commented on d39d550 Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at the moment. The tasks I want to finish this week:

  1. https://github.com/SSilence/selfoss/tree/jsx-init JSX is much nicer than template strings, just need to move eslint to assets so if can pick up babel configuration.
  2. Change icons to vector #1013 I have rebased this locally, just small details remain.
  3. Render sources in navigation client-side #1064 Initially, we wanted to use a trmplating engine but with Parcel, we can jist use JSX directly. I need to change it to that and determine if it is viable for dynamic content without React.
  4. Consolidate the documentation #979 currently researching the benefits of Asciidoc vs reStructuredText

@akash07k
Copy link
Contributor

@akash07k akash07k commented on d39d550 Oct 4, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.