Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variable: _record_input_props: Array[PropertyEntry] #250

Closed
TheYellowArchitect opened this issue Aug 23, 2024 · 0 comments · Fixed by #320
Closed

Unused variable: _record_input_props: Array[PropertyEntry] #250

TheYellowArchitect opened this issue Aug 23, 2024 · 0 comments · Fixed by #320

Comments

@TheYellowArchitect
Copy link
Contributor

TheYellowArchitect commented Aug 23, 2024 •
edited
Loading

In the class RollbackSynchronizer
It is set, and it is cleared, but it is never used anywhere in the project. Does it have a purpose in this version, or was it a leftover? _auth_input_props does everything required after all. Perhaps it was exclusively to be used by the server? (so the server uses _record_input_props instead of _auth_input_props ?
@TheYellowArchitect TheYellowArchitect changed the title _record_input_props: Array[PropertyEntry] is unused Unused variable: _record_input_props: Array[PropertyEntry] Aug 23, 2024
@TheYellowArchitect TheYellowArchitect mentioned this issue Aug 26, 2024
Closed
@TheYellowArchitect TheYellowArchitect mentioned this issue Sep 14, 2024
Closed
@TheYellowArchitect TheYellowArchitect mentioned this issue Oct 16, 2024
Closed
@elementbound elementbound mentioned this issue Nov 3, 2024
Merged
elementbound added a commit that referenced this issue Nov 3, 2024
@elementbound
fix: Use record input props instead of auth (#320)
c235892 
Fixes #250, Supersedes #309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use record input props instead of auth foxssake/netfox
1 participant
@TheYellowArchitect