Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Problems with multiplayer-netfox example #135

Merged
merged 6 commits into from
Nov 25, 2023
Merged

fix: Problems with multiplayer-netfox example #135

merged 6 commits into from
Nov 25, 2023

Conversation

zibetnu
Copy link
Contributor

@zibetnu zibetnu commented Nov 24, 2023

I ran into three issues when taking a look at the netfox example.

First, the connect_ui issue mentioned in #134 showed up here as well. I applied the same fix.

Second, I noticed that the player's _tick function wasn't getting called. It looks like it should be connected to NetworkTime's on_tick signal, so I went ahead and did that as a fix.

Third, I can't get the players to move and haven't figured out why. The input works and velocity is set, but nothing noticeable happens when move_and_slide is called. Hopefully you'll know what needs to be done to fix this, and then the fix can be part of this or a different pull request.

Oh also, Godot automatically removed a line from player.tscn and I thought it was relevant enough to be part of this pull request.

Copy link
Contributor

@elementbound elementbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @zibetnu! I've suggested some changes, which I'm happy to implement myself. Let me know if you'd like to tackle the updates :)
If not, I can either open a new PR based on your changes, or update your fork if you give me write permission.

examples/multiplayer-netfox/scripts/player.gd Outdated Show resolved Hide resolved
@zibetnu
Copy link
Contributor Author

zibetnu commented Nov 25, 2023

Done! I decided to make those changes myself because I'm trying to familiarize myself with netfox anyway.

I also invited you to have write access. Please let me know if there was a better way to do that.

@elementbound elementbound merged commit ca9b4c4 into foxssake:main Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants