Fperrin funcdef arguments optional #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
fperrin
force-pushed
the
fperrin-funcdef-arguments-optional
branch
from
5614cd1
to
0198b68
Compare
This comment has been minimized.
This comment has been minimized.
When FuncDef is deserialized we don't reconstruct the arguments. Previous code was deleting the attribute, leading to python#11899; instead, always set the attribute, maybe to None, and mypy can remind us to check for not None before use.
fperrin
force-pushed
the
fperrin-funcdef-arguments-optional
branch
from
0198b68
to
370a035
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC for python#12324