Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fperrin funcdef arguments optional #3

Closed
wants to merge 2 commits into from
Closed

Fperrin funcdef arguments optional #3

wants to merge 2 commits into from

Commits on Mar 22, 2022

  1. Test for undefined FuncDef.arguments after deserialize from cache

    @fperrin
    fperrin committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    e04a4b4 View commit details
    Browse the repository at this point in the history

  2. Make FuncItem.arguments optional 

    When FuncDef is deserialized we don't reconstruct the arguments.
Previous code was deleting the attribute, leading to python#11899; instead,
always set the attribute, maybe to None, and mypy can remind us to
check for not None before use.
    @fperrin
    fperrin committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    370a035 View commit details
    Browse the repository at this point in the history