Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pdm): handle PEP 621 dev groups #637

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

mkniewallner
Copy link
Collaborator

Since PDM is based on PEP 621, we should probably also handle the new option added in #628.

This also fixes the logging by moving the logic to core, otherwise we would log dev depencencies twice for PDM (once in PEP621DependencyGetter and once in PDMDependencyGetter.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.7%. Comparing base (8b8b4e1) to head (437b043).
Report is 5 commits behind head on pep621-dev-deps.

Files Patch % Lines
python/deptry/core.py 85.7% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           pep621-dev-deps    #637     +/-   ##
=================================================
+ Coverage             90.5%   90.7%   +0.2%     
=================================================
  Files                   33      33             
  Lines                  985     986      +1     
  Branches               194     198      +4     
=================================================
+ Hits                   892     895      +3     
+ Misses                  79      74      -5     
- Partials                14      17      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner marked this pull request as ready for review March 23, 2024 17:55
@fpgmaas fpgmaas merged commit 7eead0f into pep621-dev-deps Mar 23, 2024
28 of 29 checks passed
@fpgmaas fpgmaas deleted the handle-pep-621-groups-pdm branch March 23, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants