fix: journals as invoice throwing validation error (backport #1185) (#…

…1187) allocating payment entries against multi-currency journal entries as invoice with the same exchange rate should not create gain_loss journals (cherry picked from commit 50eaaca) Co-authored-by: ruthra kumar <[email protected]>
frappe · Dec 15, 2023 · ed63f5a · ed63f5a
1 parent 0e07f30
commit ed63f5a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/hrms/overrides/employee_payment_entry.py b/hrms/overrides/employee_payment_entry.py
@@ -42,7 +42,7 @@ def set_missing_ref_details(
 				)
 
 				for field, value in ref_details.items():
-					if d.exchange_gain_loss:
+					if d.exchange_gain_loss is not None:
 						# for cases where gain/loss is booked into invoice
 						# exchange_gain_loss is calculated from invoice & populated
 						# and row.exchange_rate is already set to payment entry's exchange rate