Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Employee Dashboard must accomodate Document Links #1103

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

marination
Copy link
Contributor

  • Document Links added via Customize Form/Doctype aren't added to the Employee dashboard
    Screenshot 2023-11-24 at 4 28 07 PM
    Screenshot 2023-11-24 at 4 32 24 PM

Fix

  • Extend data in the dashboard override, don't invalidate data
    Screenshot 2023-11-24 at 4 31 04 PM

- Don't override incoming `data` instead add to it
@ruchamahabal ruchamahabal changed the title fix: Dashboard must accomodate Document Links fix: Employee Dashboard must accomodate Document Links Nov 28, 2023
@ruchamahabal ruchamahabal merged commit e802cf9 into frappe:develop Nov 28, 2023
9 checks passed
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
- Don't override incoming `data` instead add to it

(cherry picked from commit e802cf9)
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
- Don't override incoming `data` instead add to it

(cherry picked from commit e802cf9)
ruchamahabal pushed a commit that referenced this pull request Nov 28, 2023
- Don't override incoming `data` instead add to it

(cherry picked from commit e802cf9)

Co-authored-by: Marica <[email protected]>
ruchamahabal pushed a commit that referenced this pull request Nov 28, 2023
- Don't override incoming `data` instead add to it

(cherry picked from commit e802cf9)

Co-authored-by: Marica <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Nov 29, 2023
## [14.18.1](v14.18.0...v14.18.1) (2023-11-29)

### Bug Fixes

* Dashboard must accomodate Document Links ([#1103](#1103)) ([#1120](#1120)) ([72d316e](72d316e))
* Employee role perms for Employee Grievance and Grievance Type ([#1115](#1115)) ([#1118](#1118)) ([5857822](5857822))
* handle null & empty shift ('') values in Monthly Attendance Sheet ([#1123](#1123)) ([#1125](#1125)) ([2e5946a](2e5946a))
* move translations from erpnext ([#1114](#1114)) ([e3f6a25](e3f6a25))
* rendering of Leaves with Half Day in Calendar View ([#1116](#1116)) ([bf4e03c](bf4e03c))
frappe-pr-bot pushed a commit that referenced this pull request Nov 29, 2023
## [15.4.1](v15.4.0...v15.4.1) (2023-11-29)

### Bug Fixes

* Dashboard must accomodate Document Links ([#1103](#1103)) ([#1121](#1121)) ([42c9591](42c9591))
* Employee role perms for Employee Grievance and Grievance Type ([#1115](#1115)) ([#1119](#1119)) ([db7ce38](db7ce38))
* handle null & empty shift ('') values in Monthly Attendance Sheet ([#1123](#1123)) ([#1126](#1126)) ([69160de](69160de))
* rendering of Leaves with Half Day in Calendar View ([#1117](#1117)) ([da639b3](da639b3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants