fix: handle null & empty shift ('') values in Monthly Attendance Sheet #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1123 +/- ##
========================================
Coverage 73.06% 73.06%
========================================
Files 199 199
Lines 10714 10716 +2
========================================
+ Hits 7828 7830 +2
Misses 2886 2886
|
ruchamahabal
added a commit
that referenced
this pull request
Nov 29, 2023
#1123) (#1125) * fix: handle null & empty shift ('') values in Monthly Attendance Sheet * test: empty shift check (cherry picked from commit 39eb9c4) Co-authored-by: Rucha Mahabal <[email protected]>
ruchamahabal
added a commit
that referenced
this pull request
Nov 29, 2023
#1123) (#1126) * fix: handle null & empty shift ('') values in Monthly Attendance Sheet * test: empty shift check (cherry picked from commit 39eb9c4) Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
## [14.18.1](v14.18.0...v14.18.1) (2023-11-29) ### Bug Fixes * Dashboard must accomodate Document Links ([#1103](#1103)) ([#1120](#1120)) ([72d316e](72d316e)) * Employee role perms for Employee Grievance and Grievance Type ([#1115](#1115)) ([#1118](#1118)) ([5857822](5857822)) * handle null & empty shift ('') values in Monthly Attendance Sheet ([#1123](#1123)) ([#1125](#1125)) ([2e5946a](2e5946a)) * move translations from erpnext ([#1114](#1114)) ([e3f6a25](e3f6a25)) * rendering of Leaves with Half Day in Calendar View ([#1116](#1116)) ([bf4e03c](bf4e03c))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
## [15.4.1](v15.4.0...v15.4.1) (2023-11-29) ### Bug Fixes * Dashboard must accomodate Document Links ([#1103](#1103)) ([#1121](#1121)) ([42c9591](42c9591)) * Employee role perms for Employee Grievance and Grievance Type ([#1115](#1115)) ([#1119](#1119)) ([db7ce38](db7ce38)) * handle null & empty shift ('') values in Monthly Attendance Sheet ([#1123](#1123)) ([#1126](#1126)) ([69160de](69160de)) * rendering of Leaves with Half Day in Calendar View ([#1117](#1117)) ([da639b3](da639b3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
null and empty shift ("") being treated as 2 different shifts in attendance sheet
After: