fix: journals as invoice throwing validation error (backport #1185) #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
allocating payment entries against multi-currency journal entries as invoice with the same exchange rate should not create gain_loss journals (cherry picked from commit 50eaaca)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## version-14-hotfix #1186 +/- ##
==================================================
Coverage 74.30% 74.31%
==================================================
Files 193 193
Lines 10154 10154
==================================================
+ Hits 7545 7546 +1
+ Misses 2609 2608 -1
|
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 23, 2023
# [14.20.0](v14.19.0...v14.20.0) (2023-12-23) ### Bug Fixes * consider previous Leave Applications while enforcing Maximum Consecutive Leaves Allowed ([d42500b](d42500b)) * dont consider holidays while checking for consecutive leaves ([baf4236](baf4236)) * Half Day Leave Application Link To Half Day Attendance (backport [#1147](#1147)) ([#1201](#1201)) ([28a840b](28a840b)) * journals as invoice throwing validation error (backport [#1185](#1185)) ([#1186](#1186)) ([71d134f](71d134f)) * permission sensitivity ([dad51de](dad51de)) * rewrite attendance query in qb ([75cec25](75cec25)) * translations ([93a5d36](93a5d36)) ### Features * better error msg ([4b0a0c7](4b0a0c7)) ### Reverts * Revert "fix: journals as invoice throwing validation error" (backport #1192) (#1193) ([177d957](177d957)), closes [#1192](#1192) [#1193](#1193)
|
🎉 This PR is included in version 14.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1185 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com