Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bold in group by and options mapping (backport #1564) #1579

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 26, 2024

Version 15 and 14

fixes: #1554 and
https://discuss.frappe.io/t/monthly-attendance-sheet-group-by-getting-html-tag-strong/119269?u=ncp

Before:

  • When you use the 'group by' function, the <strong> tag shows up and looks messy. Additionally, all links lead directly to the branch doctype.
before_MAS_1.mp4

After:

  • To fix this, we removed the frappe.bold from py and added a condition in the formatter in js. We also corrected the options_mapping.
after_MAS_1.mp4

Thank You!


This is an automatic backport of pull request #1564 done by Mergify.

* fix: bold in group by and options mapping

* fix: bold in group by and options mapping

(cherry picked from commit f1c3de2)
@mergify mergify bot requested a review from ruchamahabal as a code owner March 26, 2024 06:41
@ruchamahabal ruchamahabal merged commit 4fd79b4 into version-14-hotfix Mar 26, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-1564 branch March 26, 2024 07:03
frappe-pr-bot pushed a commit that referenced this pull request Mar 27, 2024
## [14.24.2](v14.24.1...v14.24.2) (2024-03-27)

### Bug Fixes

* add filter for employee in vehicle log (backport [#1571](#1571)) ([#1581](#1581)) ([92331aa](92331aa))
* bold in group by and options mapping (backport [#1564](#1564)) ([#1579](#1579)) ([4fd79b4](4fd79b4))
* incorrect IFSC codes in bank remittance report (backport [#1538](#1538)) ([#1583](#1583)) ([2c08519](2c08519))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.24.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants