fix: use reference name while updating exc rate (backport #1623) #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit a24fbd0)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## version-15-hotfix #1635 +/- ##
=====================================================
+ Coverage 72.84% 72.86% +0.02%
=====================================================
Files 202 202
Lines 11168 11191 +23
=====================================================
+ Hits 8135 8154 +19
- Misses 3033 3037 +4
|
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
# [15.17.0](v15.16.0...v15.17.0) (2024-04-10) ### Bug Fixes * assignment link in tax slab validation ([fc23a21](fc23a21)) * employee filter in list view of shift assignment (backport [#1624](#1624)) ([#1627](#1627)) ([38030b5](38030b5)) * shift type filter in list view of shift assignment (backport [#1625](#1625)) ([#1629](#1629)) ([e8fc0f0](e8fc0f0)) * use reference name while updating exc rate (backport [#1623](#1623)) ([#1635](#1635)) ([d5a45f2](d5a45f2)) * validate/warn overwriting tax in additional salary ([fa833e0](fa833e0)) ### Features * add total row for single employee & leave type ([7d8a3c5](7d8a3c5)) * add transaction type & name filter ([bb967ae](bb967ae)) * add View Ledger buttons to leave transactions ([6f630ac](6f630ac)) * Leave Ledger Report ([9be6701](9be6701)) * **Payroll:** allow overwriting tax component through additional salary ([ac23771](ac23771)) * show holidays and colour code in attendance calendar ([75c1e16](75c1e16))
|
🎉 This PR is included in version 15.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues: #1553
parent change in ERPNext: frappe/erpnext#40856
Previous fix wasn't working as expected.
This is an automatic backport of pull request #1623 done by Mergify.