fix: unwanted Exc Gain/Loss journals on Payment against Journal entry #40856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
ruthra-kumar
force-pushed
the
better_approach_for_exc_rate_updating
branch
from
f42b56a
to
fe84558
Compare
ruthra-kumar
added
backport version-14-hotfix
This was referenced Apr 5, 2024
Merged
ruthra-kumar
added a commit
that referenced
this pull request
Apr 5, 2024
…-40856 fix: unwanted Exc Gain/Loss journals on Payment against Journal entry (backport #40856)
ruthra-kumar
added a commit
that referenced
this pull request
Apr 5, 2024
…-40856 fix: unwanted Exc Gain/Loss journals on Payment against Journal entry (backport #40856)
This was referenced Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues: #40511
Replication:
Only [2] should have Exchange Gain/Loss Journal
companion PR for HRMS: frappe/hrms#1623