This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 359
Update README Based on Roadmap. Remove Stale Information #151
Merged
allella
merged 7 commits into
freeCodeCamp:master
from
allella:fix/readme-roadmap-updates
Oct 29, 2019
Merged
Update README Based on Roadmap. Remove Stale Information #151
allella
merged 7 commits into
freeCodeCamp:master
from
allella:fix/readme-roadmap-updates
Oct 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…map conversations.
…es not convert them using relative URLs
vkWeb
suggested changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allella Thank you for working on this. But I think your changes include a lot of links.
I would request you to revert to the old README.md by following these steps:
# Checkout PR's branch
$ git checkout fix/readme-roadmap-updates
# Revert to original state
$ git fetch upstream
$ git reset --hard upstream/master
Now you should make these changes to README.md:
- Remove elasticsearch from stack
- Keep TypeScript on stack not JavaScript/TypeScript
- Include roadmap issue link on the roadmap section
# Add files, commit and force push
$ git add .
$ git commit -m "fix: stack update"
$ git push origin fix/readme-roadmap-updates --force
@allella Please resolve the conflicts. Then remove JavaScript/TypeScript and replace it with just TypeScript there. Thanks for your work on this my friend ;) |
Co-Authored-By: Scott Brenner <[email protected]>
…as most were stale and/or not part of the MVP
@all-contributors please add @allella for doc |
I've put up a pull request to add @allella! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md
).master
branch of Chapter.Closes: Nothing