Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyca/cryptography library contains flaw in AES-GCM primitive #3677

Closed
emkll opened this issue Jul 31, 2018 · 0 comments · Fixed by #3679 or #3683
Closed

pyca/cryptography library contains flaw in AES-GCM primitive #3677

emkll opened this issue Jul 31, 2018 · 0 comments · Fixed by #3679 or #3683
Labels

Comments

@emkll
Copy link
Contributor

emkll commented Jul 31, 2018

Description

pyca/cryptography is used on both the app server and on the tails workstation, and should be updated due to a vulnerability in the implementation of AES-GCM: https://nvd.nist.gov/vuln/detail/CVE-2018-10903

Based on discussions with @redshiftzero, we are planning to move forward with the following:

Securedrop app server

For the SecureDrop application, we are using pyca/cryptography exclusively in the secure temp file [0,1], where we use AES in CTR mode (therefore not affected by this flaw). When switching to this library, we've encountered issues in getting the library functional in Ubuntu 14.04 (see #3441), which would make an upgrade of the library less trivial.

For the reasons above, let's wait for the Xenial migration, while closely monitoring advisories for the pyca/cryptography library. If another flaw is found, we can re-evaluate this decision.

Tails workstation

Used by Paramiko [2], which currently does not support GCM [3] (it's reasonable to assume that the AES GCM functions are not being used). However, there is no reason not to upgrade, so let's bump versions for the admin tails workstation.

Steps to Reproduce

Observe the version of the cryptography package version

Expected Behavior

The cryptography package version should be >= 2.3

Actual Behavior

The cryptography package version is < 2.3

[0] : https://github.com/freedomofpress/securedrop/blob/develop/securedrop/requirements/securedrop-app-code-requirements.txt
[1] : https://github.com/freedomofpress/securedrop/blob/develop/securedrop/secure_tempfile.py
[2] : https://github.com/freedomofpress/securedrop/blob/develop/admin/requirements.txt
[3] : paramiko/paramiko#982

emkll added a commit that referenced this issue Aug 1, 2018
This ignores the safety check failure for CVE-2018-10903. As the flaw is in AES-GCM (SecureDrop app server does not make use of AES-GCM), and that updating the dependency may require updating to Xenial or potentially introducing further risk, let's set safety to (temporarily) ignore this vulnerability. See issue #3677 for more information.
emkll added a commit that referenced this issue Aug 1, 2018
This ignores the safety check failure for CVE-2018-10903. As the flaw is in AES-GCM (SecureDrop app server does not make use of AES-GCM), and that updating the dependency may require updating to Xenial or potentially introducing further risk, let's set safety to (temporarily) ignore this vulnerability. See issue #3677 for more information.
emkll added a commit that referenced this issue Aug 1, 2018
This ignores the safety check failure for CVE-2018-10903. As the flaw is in AES-GCM (SecureDrop app server does not make use of AES-GCM), and that updating the dependency may require updating to Xenial or potentially introducing further risk, let's set safety to (temporarily) ignore this vulnerability. See issue #3677 for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants