Temporarily ignore safety check for pyca/cryptography #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ignores the safety check failure for CVE-2018-10903. As the flaw is in AES-GCM (SecureDrop app server does not make use of AES-GCM), and that updating the dependency may require updating to Xenial or potentially introducing further risk, let's set safety to (temporarily) ignore this vulnerability. See issue #3677 for more information.
redshiftzero
approved these changes
Aug 1, 2018
Codecov Report
@@ Coverage Diff @@
## develop #3683 +/- ##
========================================
Coverage 85.85% 85.85%
========================================
Files 41 41
Lines 2658 2658
Branches 288 288
========================================
Hits 2282 2282
Misses 312 312
Partials 64 64Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
NOTE: These changes should be reverted one SecureDrop app code is updated, this is tracked in #3682
Partially fixes #3677 and resolves current CI failures.
This ignores the safety check failure for CVE-2018-10903. As the flaw is in AES-GCM (SecureDrop app server does not make use of AES-GCM), and that updating the dependency may require updating to Xenial or potentially introducing further risk, let's set safety to (temporarily) ignore this vulnerability. See issue #3677 for more information.
Update of the admin workstation environment are tracked in #3679 (which will need to be rebased)
Testing
Deployment
Dev/CI env only