Add release date to track metadata #223
Conversation
Fixes #185 This commit adds the DATE metadata field to the transcoded MP3 and FLAC files. The FLAC documentation we can find seems to suggest using DATE for this purpose[1]. For MP3, `date` also seems to be an acceptable field name[2]. We've verified that the data shows up in the metadata displayed by VLC[3] for both formats. [1] https://xiph.org/vorbis/doc/v-comment.html#fieldnames [2] https://docs.mp3tag.de/format/ [3] https://www.videolan.org/vlc/ Co-authored-by: Chris Lowis <[email protected]>
This test runs a WAV file through the TranscodeJob and then ensures that the correct metadata has been added to the generated MP3 and FLAC file using `ffprobe`.
|
I'm pretty happy with where this has got to, so I plan to land it tomorrow. I don't think it's worth re-transcoding every file currently in the system to have the new metadata field, but it is something we could do - I don't think the background job machine is working very hard generally so it might be practical to retranscode to keep everything consistent. |
|
@chrislo thanks a lot for getting to this as promised 🙌🏿
Makes sense. In any case, it looks like something we can revisit should we find that it is having a disproportionate impact on performance. |
Our best understanding is that the MP3 ID3 tag TORY[1] should be used to store the *year* (i.e. as a 4-digit number) the music was released. The convention for FLAC tags seems to have even less consensus/real-world usage, so for simplicity in the code, we've decided to use the four digit year in the DATE tag. [1] https://community.mp3tag.de/t/how-do-i-add-the-tag-for-when-my-music-was-released/55319 Co-authored-by: James Mead <[email protected]>
This PR reworks #222 to get it ready to merge.
@lenikadali - thanks so much for your hard work on this! I've made a couple of small changes:
ffprobeto make it a bit easier for us to change the metadata fields in the future and have some confidence thatffmpegis doing the right thing.