fixed decoding LCB value for large feilds #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed decoding LCB value for fields > 250 bytes. according to this doc: http://dev.mysql.com/doc/internals/en/event-content-writing-conventions.html Current implementation ignored this and was hanging waiting for more packets when VARCHAR was larger than 250 bytes. There is also parseLCB function that is doing this exactly, but it seems to be not used since commit 01b30f1 this probably fixes mysql-d#18
fsw
added a commit
that referenced
this pull request
May 11, 2014
fixed decoding LCB value for large feilds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed decoding LCB value for fields > 250 bytes.
according to this doc:
http://dev.mysql.com/doc/internals/en/event-content-writing-conventions.html
Current implementation ignored this and was hanging waiting for more packets when VARCHAR was larger than 250 bytes.
There is also parseLCB function that is doing this exactly,
but it seems to be not used since commit 01b30f1
this probably fixes mysql-d#18