RaiseLower only Lowers windows in per-desktop mode in certain conditions #86
Comments
ThomasAdam
added a commit
that referenced
this issue
May 23, 2020
Previously, when StartsOnDesk was used, although the desk was correctly set, the desk would never change thereafter, once the window was moved. This was because the UPDATE_FVWM_SCREEN macro assumed it could always update the window, but never took into account that when moving monitors, the desk also needed to be changed. But this can't blindly happen in all cases, as on initla mapping of the window, the UPDATE_FVWM_SCREEN macro would have overriden the StartsOnDesk style. This change introduces a flag to track this as well as reducing the number of assigments which weren't needed when updating the screen. Also removed an extraneous assignment. Helps #86
|
Hi @NsCDE, Thanks for this. I presume the window you were moving between desk not updating correctly on As to your RaiseLower problem, I'll take a look now... |
ThomasAdam
added a commit
that referenced
this issue
May 23, 2020
Previously, when StartsOnDesk was used, although the desk was correctly set, the desk would never change thereafter, once the window was moved. This was because the UPDATE_FVWM_SCREEN macro assumed it could always update the window, but never took into account that when moving monitors, the desk also needed to be changed. But this can't blindly happen in all cases, as on initla mapping of the window, the UPDATE_FVWM_SCREEN macro would have overriden the StartsOnDesk style. This change introduces a flag to track this as well as reducing the number of assigments which weren't needed when updating the screen. Also removed an extraneous assignment. Helps #86
ThomasAdam
added a commit
that referenced
this issue
May 23, 2020
Previously, when StartsOnDesk was used, although the desk was correctly set, the desk would never change thereafter, once the window was moved. This was because the UPDATE_FVWM_SCREEN macro assumed it could always update the window, but never took into account that when moving monitors, the desk also needed to be changed. But this can't blindly happen in all cases, as on initla mapping of the window, the UPDATE_FVWM_SCREEN macro would have overriden the StartsOnDesk style. This change introduces a flag to track this as well as reducing the number of assigments which weren't needed when updating the screen. Also removed an extraneous assignment. Helps #86
ThomasAdam
added a commit
that referenced
this issue
May 23, 2020
Previously, when StartsOnDesk was used, although the desk was correctly set, the desk would never change thereafter, once the window was moved. This was because the UPDATE_FVWM_SCREEN macro assumed it could always update the window, but never took into account that when moving monitors, the desk also needed to be changed. But this can't blindly happen in all cases, as on initla mapping of the window, the UPDATE_FVWM_SCREEN macro would have overriden the StartsOnDesk style. This change introduces a flag to track this as well as reducing the number of assigments which weren't needed when updating the screen. Also removed an extraneous assignment. Helps #86
ThomasAdam
added a commit
that referenced
this issue
May 24, 2020
When deducing if the windows in the stack ring should be compared against, only consider those windows on the same monitor as the current window. Fixes #86
|
Hi @NsCDE, I suspect the Let me know how you get on. |
|
Hi Thomas, Sorry for the delay, I had lot of work this days. Just to confirm: I have tested, both RaiseLower and FvwmIdent are now behaving fine. You can close this issue I think. |
ThomasAdam
added a commit
that referenced
this issue
May 27, 2020
Previously, when StartsOnDesk was used, although the desk was correctly set, the desk would never change thereafter, once the window was moved. This was because the UPDATE_FVWM_SCREEN macro assumed it could always update the window, but never took into account that when moving monitors, the desk also needed to be changed. But this can't blindly happen in all cases, as on initla mapping of the window, the UPDATE_FVWM_SCREEN macro would have overriden the StartsOnDesk style. This change introduces a flag to track this as well as reducing the number of assigments which weren't needed when updating the screen. Also removed an extraneous assignment. Helps #86
ThomasAdam
added a commit
that referenced
this issue
May 27, 2020
When deducing if the windows in the stack ring should be compared against, only consider those windows on the same monitor as the current window. Fixes #86
mikeandmore
pushed a commit
to mikeandmore/fvwm3
that referenced
this issue
Nov 28, 2020
Previously, when StartsOnDesk was used, although the desk was correctly set, the desk would never change thereafter, once the window was moved. This was because the UPDATE_FVWM_SCREEN macro assumed it could always update the window, but never took into account that when moving monitors, the desk also needed to be changed. But this can't blindly happen in all cases, as on initla mapping of the window, the UPDATE_FVWM_SCREEN macro would have overriden the StartsOnDesk style. This change introduces a flag to track this as well as reducing the number of assigments which weren't needed when updating the screen. Also removed an extraneous assignment. Helps fvwmorg#86
mikeandmore
pushed a commit
to mikeandmore/fvwm3
that referenced
this issue
Nov 28, 2020
When deducing if the windows in the stack ring should be compared against, only consider those windows on the same monitor as the current window. Fixes fvwmorg#86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Branch: master
If I have terminal on monitor Virtual-0, desk 0, and start "someapp" on monitor Virtual-1, desk 2, and then move it with mouse to Virtual-0, it will change desk to desk 0. I can use RaiseLower builtin function to lower it if it covers app which has been initially on Virtual-0, but raise part doesn't function: it is like window moved from Virtual-1 to Virtual-0 is on the "top" layer, with exception that I can lower native window (but not raise over newcomer window again too).
This doesn't manifests if same desk is on both monitors while moving windows.
EDIT: Additionally, in FvwmIdent, info about desk of the window moved between monitors/desks is not changed, monitor is.
The text was updated successfully, but these errors were encountered: